Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Fix test 'test_update_slurm' adapting the constraint in the sbatch command to the flexible instance types used in the config #6592

Conversation

gmarciani
Copy link
Contributor

@gmarciani gmarciani commented Dec 5, 2024

Description of changes

Fix test 'test_update_slurm' adapting the constraint in the sbatch command so that it can work when flexibleinstance types are used. In 1360e74 we introduced the use of flexible instance types in the test to reduce the risk of ICEs, but the sbatch command should have been adapted accordingly. Notiuce that you cannot use instance typoes as constraints when flexible instance types are used because in that case, the instance type is not listed in CR features.

Tests

  1. Succeeded test_update_slurm.

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmarciani gmarciani changed the title [Test] Fix test 'test_update_slurm' adapting the constraint in the sb… [Test] Fix test 'test_update_slurm' adapting the constraint in the sbtch command to the flexible instance types used in the config Dec 5, 2024
@gmarciani gmarciani added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x Test labels Dec 5, 2024
@gmarciani gmarciani force-pushed the wip/mgiacomo/3120/fix-test-update-slurm-1205-1 branch from 7a692bf to 8b0a3ae Compare December 9, 2024 09:36
@gmarciani gmarciani changed the title [Test] Fix test 'test_update_slurm' adapting the constraint in the sbtch command to the flexible instance types used in the config [Test] Fix test 'test_update_slurm' adapting the constraint in the sbatch command to the flexible instance types used in the config Dec 9, 2024
…atch command to the flexible instance types used in the config.

Signed-off-by: Giacomo Marciani <[email protected]>
@gmarciani gmarciani merged commit e8bf6a1 into aws:develop Dec 10, 2024
27 checks passed
@gmarciani gmarciani deleted the wip/mgiacomo/3120/fix-test-update-slurm-1205-1 branch December 10, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x skip-changelog-update Disables the check that enforces changelog updates in PRs Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants