Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Removing color from output of ip command #6586

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

himani2411
Copy link
Contributor

@himani2411 himani2411 commented Dec 4, 2024

Description of changes

  • O/p of ip a command adds color for ALinux2023
  • Removing color from output of ip command
    ANSI code for colors like #x1B* is being added
#x1B[36mens5: #x1B[0m<BROADCAST,MULTICAST,UP,LOWER_UP> .....

Tests

  • Ran ip a | col -b on all Osses

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 requested review from a team as code owners December 4, 2024 22:09
@himani2411 himani2411 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Dec 4, 2024
@himani2411 himani2411 enabled auto-merge (squash) December 4, 2024 22:10
@himani2411 himani2411 disabled auto-merge December 4, 2024 22:14
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (916f59f) to head (b3efaf7).
Report is 47 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6586      +/-   ##
===========================================
+ Coverage    90.21%   90.23%   +0.01%     
===========================================
  Files          181      181              
  Lines        16145    16201      +56     
===========================================
+ Hits         14566    14619      +53     
- Misses        1579     1582       +3     
Flag Coverage Δ
unittests 90.23% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himani2411 himani2411 enabled auto-merge (squash) December 4, 2024 22:18
@himani2411 himani2411 merged commit 0ae3a79 into aws:develop Dec 5, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants