Added the object representation of the CloudWatch Alarm #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omposite types) Updated encoding properties to remove warnings
|
There is a design decision on whether there should be one class or two? The two different types of alarms use different attributes. |
smirnoal
approved these changes
Jun 20, 2024
smirnoal
reviewed
Jun 20, 2024
maxday
reviewed
Jun 20, 2024
...nts/src/test/java/com/amazonaws/services/lambda/runtime/events/CloudWatchAlarmEventTest.java
Outdated
Show resolved
Hide resolved
|
What do you think about having both use cases model as a single class? I think having two is awkward because some attributes won't make sense in one case. But the alternative of having two is awkward if CloudWatch continues to make different events in the future. |
maxday
reviewed
Jun 20, 2024
...-events/src/main/java/com/amazonaws/services/lambda/runtime/events/CloudWatchAlarmEvent.java
Outdated
Show resolved
Hide resolved
Moved the tests to the test module
|
Ready to recheck |
smirnoal
approved these changes
Jun 21, 2024
maxday
approved these changes
Jul 11, 2024
| @@ -35,6 +35,8 @@ | |||
| <maven.compiler.source>1.8</maven.compiler.source> | |||
| <maven.compiler.target>1.8</maven.compiler.target> | |||
| <lombok.version>1.18.22</lombok.version> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | |||
There was a problem hiding this comment.
@msailes is this change required in this PR?
There was a problem hiding this comment.
No. There was a warning in the build logs, I added these to remove the warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#484
Description of changes:
I added a test dependency to serialisation so I could write a unit test with the correct serialisation configuration for Jackson.
Target (OCI, Managed Runtime, both):
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.