Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lambda Blueprints #1880

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Update Lambda Blueprints #1880

merged 1 commit into from
Nov 25, 2024

Conversation

normj
Copy link
Member

@normj normj commented Nov 21, 2024

Description of changes:
Update the dependencies on the Lambda blueprints. The driving motivation was to get the versions of Amazon.Lambda.Core and Amazon.Lambda.RuntimeSupport updated with versions that support Lambda SnapStart.

While updating I also addressed any warnings that were generated by compiling the templates. That includes.

  • Adding null checks
  • Removing the Program.fs added in last PR because I found out by adding the IsTestProject the F# compiler will generate the entry point.

Testing

Ran the script to instantiate and compile all templates.
Manually ran some of the blueprints through Visual Studio after packaging up the blueprints for VS.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…Amazon.Lambda.RuntimeSupport that support SnapStart
@gcbeattyAWS
Copy link

do we need devconfig file for this change or is that not required?

@normj
Copy link
Member Author

normj commented Nov 21, 2024

do we need devconfig file for this change or is that not required?

I manually updated the version and change log because the templates package isn't in the AutoVer config file. @philasmar Not sure if you have a plan when you were going to add the templates to the AutoVer system.

@boblodgett boblodgett requested a review from philasmar November 22, 2024 18:34
@@ -25,6 +25,3 @@ module ValuesControllerTests =
Assert.True(response.MultiValueHeaders.ContainsKey("Content-Type"))
Assert.Equal("application/json; charset=utf-8", response.MultiValueHeaders.Item("Content-Type").[0])
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove this bit? (not sure what it does)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is part of that change I mentioned in the description about having FSharp test projects auto generate the entry point.

<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\..\src\BlueprintBaseName.1\BlueprintBaseName.1.fsproj" />
</ItemGroup>
<ItemGroup>
<Compile Include="FunctionTest.fs" />
<Compile Include="Program.fs" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No as I mentioned in the PR description I updated the F# test projects to be marked as test projects "<IsTestProject>true</IsTestProject>". So the entry point that Program.fs defined is now auto generated.

@@ -2,7 +2,7 @@

<PropertyGroup>
<PackageType>Template</PackageType>
<PackageVersion>7.3.0</PackageVersion>
<PackageVersion>7.4.0</PackageVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to your change, but we should update the autover config file to automatically update the blueprints as well now that we no longer use nuspec files.

@normj normj merged commit 8f8e5a3 into dev Nov 25, 2024
4 checks passed
@normj normj deleted the normj/blueprint-updates-2024-11-21 branch November 25, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants