Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: onboard the repo to the testing infra #1745

Merged
merged 1 commit into from
May 3, 2024
Merged

feat: onboard the repo to the testing infra #1745

merged 1 commit into from
May 3, 2024

Conversation

philasmar
Copy link
Contributor

Issue #, if available:
DOTNET-7477

Description of changes:

  • Added GitHub workflow that runs unit tests and integ tests using the testing infrastructure on PRs targeting main, dev and feature branches.
  • Updated the build project to use mono to run unit tests on Linux. Previously, they only supported Windows.
  • Added a buildspec file that the testing infrastructure will use to run the tests. The buildspec adds mono to the base image.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@philasmar philasmar requested review from ashovlin, normj and 96malhar May 2, 2024 17:06
@philasmar philasmar force-pushed the asmarp/support-tests-linux branch from 5cd1590 to 52396a8 Compare May 2, 2024 18:10
ashovlin
ashovlin reviewed May 2, 2024
View reviewed changes
.github/workflows/aws-ci.yml Outdated Show resolved Hide resolved
buildtools/build.proj Show resolved Hide resolved
@philasmar philasmar force-pushed the asmarp/support-tests-linux branch from 52396a8 to df0ddb6 Compare May 2, 2024 20:42
@philasmar philasmar requested a review from ashovlin May 2, 2024 20:43
normj
normj approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve assuming you address @ashovlin comments

@philasmar philasmar force-pushed the asmarp/support-tests-linux branch from df0ddb6 to b000988 Compare May 2, 2024 21:17
@philasmar philasmar requested a review from ashovlin May 2, 2024 21:17
@aws-sdk-dotnet-automation aws-sdk-dotnet-automation merged commit 3b5a47c into dev May 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normj normj normj approved these changes

@ashovlin ashovlin ashovlin approved these changes

@96malhar 96malhar Awaiting requested review from 96malhar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philasmar @ashovlin @normj @aws-sdk-dotnet-automation