Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.AspNetCore.SignalR.Client version to fix System.Text.Json vulnerability #883

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

gcbeattyAWS
Copy link
Contributor

@gcbeattyAWS gcbeattyAWS commented Nov 13, 2024

Issue #, if available:

Description of changes:
When building with .NET 9 we were getting

Severity	Code	Description	Project	File	Line	Suppression State
Error (active)	NU1903	Warning As Error: Package 'System.Text.Json' 6.0.8 has a known high severity vulnerability, https://github.com/advisories/GHSA-8g4q-xg66-9fp4	AWS.Deploy.ServerMode.Client

The System.Text.Json dependency comes from Microsoft.AspNetCore.SignalR.Client

image

This change updates the Microsoft.AspNetCore.SignalR.Client version that includes the patched System.Text.Json version (6.0.11)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.81%. Comparing base (589d9b9) to head (6aa5366).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #883      +/-   ##
==========================================
+ Coverage   62.39%   62.81%   +0.42%     
==========================================
  Files         279      282       +3     
  Lines       10908    10922      +14     
  Branches     1515     1517       +2     
==========================================
+ Hits         6806     6861      +55     
+ Misses       3565     3523      -42     
- Partials      537      538       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gcbeattyAWS gcbeattyAWS changed the title Pin System.Text.Json version Update Microsoft.AspNetCore.SignalR.Client version to fix System.Text.Json vulnerability Nov 14, 2024
@gcbeattyAWS gcbeattyAWS requested a review from 96malhar November 14, 2024 16:14
@gcbeattyAWS gcbeattyAWS marked this pull request as ready for review November 14, 2024 16:26
@gcbeattyAWS gcbeattyAWS merged commit 4efd115 into dev Nov 14, 2024
11 checks passed
@gcbeattyAWS gcbeattyAWS deleted the gcbeatty/net09 branch November 14, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants