fix: Generated CDK projects referencing version of System.Text.Json #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith listed vulnerabilities.
philasmar
approved these changes
Aug 28, 2024
afroz429
approved these changes
Aug 28, 2024
dscpinheiro
reviewed
Aug 28, 2024
...S.Deploy.Recipes/CdkTemplates/ConsoleAppECSFargateService/ConsoleAppEcsFargateService.csproj
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #850 +/- ##
=======================================
Coverage 62.35% 62.35%
=======================================
Files 279 279
Lines 10900 10900
Branches 1513 1513
=======================================
Hits 6797 6797
Misses 3566 3566
Partials 537 537 ☔ View full report in Codecov by Sentry. |
dscpinheiro
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-toolkit-visual-studio#462
Description of changes:
The generated CDK projects have
TreatWarningsAsErrorsas true which makes deployments start failing immediately when a dependency has a listed vulnerability. In this case System.Text.Json has a listed failure which causes the generated CDK project fail to build preventing deployment.This PR updates the version of
System.Text.Jsonwhich was actually coming in as a transitive dependency fromMicrosoft.Extensions.Configuration.Json. It also removes theTreatWarningsAsErrorsproperty from the generated projects because we have no control when a package might be listed as vulnerable and we don't one deployments to just start failing when that happens.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.