feat: Expose Load Balancer Scheme for EB Recipes #838
Conversation
…oad Balancer when deploying an Elastic Beanstalk application into a VPC
ashovlin
force-pushed
the
shovlia/eb-internal-lbs
branch
from
8fb4de8 to
0964d21
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #838 +/- ##
===========================================
+ Coverage 32.41% 61.57% +29.16%
===========================================
Files 272 278 +6
Lines 10746 10801 +55
Branches 1482 1492 +10
===========================================
+ Hits 3483 6651 +3168
+ Misses 6974 3612 -3362
- Partials 289 538 +249 ☔ View full report in Codecov by Sentry. |
| "Id": "LoadBalancerScheme", | ||
| "Name": "Load Balancer Scheme", | ||
| "Category": "LoadBalancer", | ||
| "Description": "Specify \"Internal\" if your application serves requests only from connected VPCs. Public load balancers serve requests from the Internet.", |
There was a problem hiding this comment.
nit: add quotes around "public" and make both "Internal" and "Public" lowercase to indicate what the actual values are.
There was a problem hiding this comment.
Will do, waiting for other reviewer's feedback before rework.
There was a problem hiding this comment.
Added quotes around "Public" via https://github.com/aws/aws-dotnet-deploy/compare/728ba2390e178d1ed44c2a832458ddcefee621e9..69845e4684d83f12f2ba998f5abb889dbbc86897
I left them capitalized since that's what we're showing in the UI (even though they're lowercase in CDK)
| "Id": "LoadBalancerScheme", | ||
| "Name": "Load Balancer Scheme", | ||
| "Category": "LoadBalancer", | ||
| "Description": "Specify \"Internal\" if your application serves requests only from connected VPCs. Public load balancers serve requests from the Internet.", |
There was a problem hiding this comment.
nit: add quotes around "public" and make both "Internal" and "Public" lowercase to indicate what the actual values are.
There was a problem hiding this comment.
Added quotes around "Public" via https://github.com/aws/aws-dotnet-deploy/compare/728ba2390e178d1ed44c2a832458ddcefee621e9..69845e4684d83f12f2ba998f5abb889dbbc86897
ashovlin
force-pushed
the
shovlia/eb-internal-lbs
branch
from
728ba23 to
69845e4
Compare
Issue #, if available: DOTNET-7553
Description of changes:
This adds a new option setting for "Load Balancer Scheme" to Linux and Windows Elastic Beanstalk recipes.
This is only visible when:
This corresponds to the
ELBSchemeoption in theaws:ec2:vpcnamespace: https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/command-options-general.html#command-options-general-ec2vpcNote: I didn't add an integration test for this because it requires valid VPC selections, and I don't believe we're covering every possible option. Let me know if you think we should add one.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.