Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping for Lambda invocation that selects which account to run integration tests in #815

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

ashovlin
Copy link
Member

@ashovlin ashovlin commented Mar 5, 2024

Issue #, if available: N/A

Description of changes: Same as awslabs/aws-dotnet-messaging#94, I'm still not sure what changed that led to this but fixing it up.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.34%. Comparing base (74bb0e8) to head (22c6e5a).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #815   +/-   ##
=======================================
  Coverage   32.34%   32.34%           
=======================================
  Files         271      271           
  Lines       10604    10604           
  Branches     1474     1474           
=======================================
  Hits         3430     3430           
  Misses       6885     6885           
  Partials      289      289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashovlin
Copy link
Member Author

ashovlin commented Mar 6, 2024

Now the tests are running, but the CI is failing for a different reason. Looks like the version of CDK the Blazor recipe is using is attempting to deploy a Node 14 Lambda which is no longer supported. We'll look at upgrading the CDK dependency in another PR.

@ashovlin ashovlin merged commit 28fa232 into dev Mar 6, 2024
8 of 11 checks passed
@ashovlin ashovlin deleted the shovlia/ci-lambda-escaping branch March 6, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants