Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Disambiguate GitHub job IDs to fix required status checks #814

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

ashovlin
Copy link
Member

@ashovlin ashovlin commented Mar 1, 2024

Issue #, if available: N/A

Description of changes: We noticed while attempting to merge #813 that we were unable to.

  • GitHub checks are failing because the PR is from a fork. Typically a maintainer will review, run tests locally if necessary, then merge despite the failures.
  • However we recently cleaned up our GitHub team structure, which removed the ability to merge despite failing checks for most maintainers.
  • This repository is configured to require on the build status check, but we had used that name across different actions, so more were required than what we intended.

I think this was unintentional, so I'm renaming these actions so that the only build one is the build+unit tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ashovlin ashovlin merged commit 0a6b252 into dev Mar 4, 2024
6 of 8 checks passed
@ashovlin ashovlin deleted the shovlia/ci-distinguish-checks branch March 4, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants