Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
normj committed Oct 18, 2024
1 parent 56e1b53 commit e75a54a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/AWS.Deploy.Orchestration/DeploymentBundleHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ private void SwitchToSelfContainedBuildIfNeeded(Recommendation recommendation)
if (string.IsNullOrEmpty(targetFramework))
return;

// Elastic Beanstalk doesn't currently have .NET 7 preinstalled.
// Elastic Beanstalk doesn't currently have .NET 7 and 9 preinstalled.
var unavailableFramework = new List<string> { "net7.0", "net9.0" };
var frameworkNames = new Dictionary<string, string> { { "net7.0", ".NET 7" }, { "net9.0", ".NET 9" } };
if (unavailableFramework.Contains(targetFramework))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ private void ConfigureBeanstalkEnvironment(bool newDeployment, Configuration set
};

if (newDeployment ||
(newDeployment && !string.Equals(settings.IMDSv1Access, IMDS_V1_DEFAULT, StringComparison.InvariantCultureIgnoreCase)))
(!newDeployment && !string.Equals(settings.IMDSv1Access, IMDS_V1_DEFAULT, StringComparison.InvariantCultureIgnoreCase)))
{
var computedDisableIMDSv1 = string.Equals(settings.IMDSv1Access, IMDS_V1_ENABLED, StringComparison.InvariantCultureIgnoreCase) ? "false" : "true";
optionSettingProperties.Add(new CfnEnvironment.OptionSettingProperty
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ private void ConfigureBeanstalkEnvironment(bool newDeployment, Configuration set
};

if (newDeployment ||
(newDeployment && !string.Equals(settings.IMDSv1Access, IMDS_V1_DEFAULT, StringComparison.InvariantCultureIgnoreCase)))
(!newDeployment && !string.Equals(settings.IMDSv1Access, IMDS_V1_DEFAULT, StringComparison.InvariantCultureIgnoreCase)))
{
var computedDisableIMDSv1 = string.Equals(settings.IMDSv1Access, IMDS_V1_ENABLED, StringComparison.InvariantCultureIgnoreCase) ? "false" : "true";
optionSettingProperties.Add(new CfnEnvironment.OptionSettingProperty
Expand Down

0 comments on commit e75a54a

Please sign in to comment.