fix: option setting updatable flag causes issues in toolkit

aws · Oct 8, 2021 · 24c8dff · 24c8dff
1 parent a3f2b6f
commit 24c8dff
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/AWS.Deploy.CLI/ServerMode/Controllers/DeploymentController.cs b/src/AWS.Deploy.CLI/ServerMode/Controllers/DeploymentController.cs
@@ -185,7 +185,8 @@ private List<OptionSettingItemSummary> ListOptionSettingSummary(Recommendation r
                     TypeHint = setting.TypeHint?.ToString(),
                     Value = recommendation.GetOptionSettingValue(setting),
                     Advanced = setting.AdvancedSetting,
-                    Updatable = (!recommendation.IsExistingCloudApplication || setting.Updatable) && recommendation.IsOptionSettingDisplayable(setting),
+                    ReadOnly = recommendation.IsExistingCloudApplication && !setting.Updatable,
+                    Visible = recommendation.IsOptionSettingDisplayable(setting),
                     AllowedValues = setting.AllowedValues,
                     ValueMapping = setting.ValueMapping,
                     ChildOptionSettings = ListOptionSettingSummary(recommendation, setting.ChildOptionSettings)
@@ -263,7 +264,7 @@ public async Task<IActionResult> GetExistingDeployments(string sessionId)
 
             var deployedApplicationQueryer = serviceProvider.GetRequiredService<IDeployedApplicationQueryer>();
             var session = CreateOrchestratorSession(state);
-            
+
             //ExistingDeployments is set during StartDeploymentSession API. It is only updated here if ExistingDeployments was null.
             state.ExistingDeployments ??= await deployedApplicationQueryer.GetCompatibleApplications(state.NewRecommendations.ToList(), session: session);
 

diff --git a/src/AWS.Deploy.CLI/ServerMode/Models/OptionSettingItemSummary.cs b/src/AWS.Deploy.CLI/ServerMode/Models/OptionSettingItemSummary.cs
@@ -22,7 +22,9 @@ public class OptionSettingItemSummary
 
         public bool Advanced { get; set; }
 
-        public bool Updatable { get; set; }
+        public bool ReadOnly { get; set; }
+
+        public bool Visible { get; set; }
 
         public IList<string> AllowedValues { get; set; } = new List<string>();