Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assetlibraryhistory: fix some errors and add test to show the errors #193

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

aaronatbissell
Copy link
Contributor

@aaronatbissell aaronatbissell commented Feb 26, 2024

Description

assetlibraryhistory has a couple of use-cases where we are seeing errors. In order to call those out, I've added a few unit tests with some test data. This includes:

  1. Update events where some of the event data stored in dynamo is undefined
  2. An update event where the latest entry doesn't exist
  3. Some optional parameters that were previously required

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (existing code being refactored)
  • This change includes a documentation update

Submission Checklist

  • CI dry-run passing
  • Integration tests passing locally
  • Change logs generated
Additional Notes:

@ts-amz
Copy link
Contributor

ts-amz commented Feb 27, 2024

Thank you for your PR, it's on our radar for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants