Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] S3 200 errors #9055

Merged
merged 12 commits into from
Nov 8, 2024
Merged

[v2] S3 200 errors #9055

merged 12 commits into from
Nov 8, 2024

Conversation

aemous
Copy link
Contributor

@aemous aemous commented Nov 5, 2024

Issue #, if available:

Description of changes:

  • Ports botocore changes to handle S3 HTTP 200 OK errors.

Description of tests:

  • Ran and passed all unit & functional tests included in the PRs linked above.
  • Ran all existing tests to ensure these changes don't break existing correctness.
  • Added 1 functional test to ensure the CLI does not break given a response from botocore in the case a 200 OK error is encountered from S3.
  • Manually tested the built application via S3 commands to ensure heuristic correctness of the product.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aemous aemous requested review from aws-sdk-python-automation and a team November 5, 2024 14:41
awscli/botocore/handlers.py Outdated Show resolved Hide resolved
Copy link
Member

@ashovlin ashovlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably rebase on 23fe898 to fix the CI, but the change looks good to me.

.changes/next-release/enhancement-s3-70184.json Outdated Show resolved Hide resolved
tests/functional/s3/test_mv_command.py Outdated Show resolved Hide resolved
@aemous aemous dismissed SamRemis’s stale review November 7, 2024 20:15

Addressed changes

@aemous aemous merged commit bf05341 into aws:v2 Nov 8, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants