Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli-integ): new test case for proxied requests #32254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(cli-integ): new test case for proxied requests #32254

wants to merge 1 commit into from
+746 −32

Conversation

otaviomacedo
Copy link
Contributor

This important scenario was missing from the integ test suite.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@otaviomacedo otaviomacedo requested a review from a team as a code owner November 22, 2024 16:34
@aws-cdk-automation aws-cdk-automation requested a review from a team November 22, 2024 16:34
@github-actions github-actions bot added the p2 label Nov 22, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 22, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Nov 22, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.17%. Comparing base (01f2dcd) to head (42e5237).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #32254   +/-   ##
=======================================
  Coverage   77.17%   77.17%           
=======================================
  Files         105      105           
  Lines        7169     7169           
  Branches     1315     1315           
=======================================
  Hits         5533     5533           
  Misses       1455     1455           
  Partials      181      181
Flag Coverage Δ
suite.unit 77.17% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.17% <0.00%> (ø)
---- 🚨 Try these New Features:

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 42e5237
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

otaviomacedo
otaviomacedo commented Nov 23, 2024
View reviewed changes
packages/aws-cdk/lib/api/aws-auth/awscli-compatible.ts
@@ -179,7 +179,7 @@ function getRegionFromIniFile(profile: string, data?: any) {
function tryGetCACert(bundlePath?: string) {
const path = bundlePath || caBundlePathFromEnvironment();
if (path) {
debug('Using CA bundle path: %s', bundlePath);
debug('Using CA bundle path: %s', path);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codecov is failing because we don't have any unit test for this part, but the integ test in this PR covers precisely this branch.

@otaviomacedo otaviomacedo added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Nov 23, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 23, 2024 18:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@otaviomacedo @aws-cdk-automation