feat(elasticloadbalancingv2): ip address type for both network and application target group #32189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
distinguished-contributor
badmintoncryer
commented
Nov 19, 2024
| @@ -84,7 +106,7 @@ export interface HealthCheck { | |||
| * The approximate number of seconds between health checks for an individual target. | |||
| * Must be 5 to 300 seconds | |||
| * | |||
| * @default 10 seconds if protocol is `GENEVE`, 35 seconds if target type is `lambda`, else 30 seconds | |||
| * @default - 10 seconds if protocol is `GENEVE`, 35 seconds if target type is `lambda`, else 30 seconds | |||
There was a problem hiding this comment.
I have corrected the usage of hyphens in some @default descriptions. If it is preferable, I can separate this into a different PR.
badmintoncryer
commented
Nov 19, 2024
| /** | ||
| * The type of IP addresses of the targets registered with the target group. | ||
| * | ||
| * @default undefined - ELB defaults to IPv4 |
There was a problem hiding this comment.
I think @default IPv4 is sufficient, but I have written it this way because several maintainers have recently recommended this approach.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32189 +/- ##
=======================================
Coverage 77.18% 77.18%
=======================================
Files 105 105
Lines 7161 7161
Branches 1312 1312
=======================================
Hits 5527 5527
Misses 1454 1454
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
added
the
pr/needs-community-review
badmintoncryer
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
None
Reason for this change
Both Application and Network target group supports for specifying IP address type.
Application: https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-target-groups.html#target-group-ip-address-type
Network: https://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-target-groups.html#target-group-ip-address-type
Description of changes
TargetGroupIpAddressTypeenumIpAddressTypeinaws-elassticloadbalancingv2module, I don't nameIpAddressTypeipAddressTypeprop toBaseTargetGroupPropsDescription of how you validated changes
Add both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license