Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React 18 migration #895

Merged
merged 27 commits into from
May 31, 2023
Merged

React 18 migration #895

merged 27 commits into from
May 31, 2023

Conversation

xuesichao
Copy link
Contributor

Issue #786 :

Description of changes:

  • Migrate SDK to react 18 based.
  • Migrate storybook to v7.
  • Migrate stories to ArgTypes based.
  • Add support for react 18.

Testing

  1. Have you successfully run npm run build:release locally?
    Yes

  2. How did you test these changes?

  • Manually verified each story by running storybook and compare to existing one.
  • Tested backwards compatibility in integration test demo and meeting demo.
  1. If you made changes to the component library, have you provided corresponding documentation changes?
    N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

xuesichao and others added 23 commits May 12, 2023 15:50
@xuesichao
Migrate stories of Badge, Button, Checkbox and FormField to addon-con…
19a5493 
…trols
@xuesichao
Migrate from themeprovider-storybook to @storybook/addon-styling
c6aa319
@xuesichao
Deprecate SFC
387edf4
@xuesichao
List children prop explicitly in type definition
7642ce5
@xuesichao
Run linter to fix format issue
8acaa75
@xuesichao
Fix type error in PopOver
803ef94
@xuesichao
Migrate integration test demo to react 18
e18dd4d
@xuesichao
Migrate to storybook v7
9f9bee2
@xuesichao
Rename *.stories.mdx files to *.mdx
2d97b87
@xuesichao
Migrate stories for SDK Components
97cd49b
@xuesichao
Migrate stories for Providers and Hooks
7341793
@xuesichao
Export components from their declaration statement to be able to popu…
638b0d4 
…late ArgTypes

Check this storybook issue: storybookjs/storybook#13304 (comment).
@xuesichao
Migrate stories of Badge, Button, Checkbox and FormField to storybook…
72a3421 
… v7 style
@xuesichao
Migrate Radio UI Component
e60b43e
@xuesichao
Upgrade styled-components to latest version
50f61ef
@xuesichao
Migrate stories for icons
3dff0dc
@devalevenkatesh @xuesichao
Upgrade Flex component story
e44ccf0
@devalevenkatesh @xuesichao
Fix flex stack story
d9b8feb
@xuesichao
Migrate stories for several components
9ea793d
@xuesichao
Migrate stories for more components
e2ecb8f
@xuesichao
Migrate more stories for components
dcb710d
@xuesichao
Migrate stories for reset components
8f1a867
@xuesichao
Add copyright and changelog
4b47af3
@xuesichao xuesichao requested a review from a team as a code owner May 12, 2023 23:30
devalevenkatesh
devalevenkatesh reviewed May 15, 2023
View reviewed changes
.storybook/main.ts Outdated Show resolved Hide resolved
devalevenkatesh
devalevenkatesh reviewed May 15, 2023
View reviewed changes
.babelrc.json Outdated Show resolved Hide resolved
michhyun1
michhyun1 previously approved these changes May 16, 2023
View reviewed changes
@xuesichao xuesichao dismissed stale reviews from michhyun1 and devalevenkatesh via a415b98 May 17, 2023 17:28
samspycher
samspycher previously approved these changes May 17, 2023
View reviewed changes
kdsbatra
kdsbatra previously approved these changes May 18, 2023
View reviewed changes
@simmkyu simmkyu dismissed stale reviews from kdsbatra, devalevenkatesh, and samspycher via 9c9a4e5 May 24, 2023 22:14
xuesichao
xuesichao commented May 24, 2023
View reviewed changes
Copy link
Contributor Author

@xuesichao xuesichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simmkyu
Re-generate package-lock.json to mitigate "... when your package.json…
dc0d384 
… and package-lock.json or npm-shrinkwrap.json are in sync" error
@simmkyu simmkyu merged commit 01bca2b into main May 31, 2023
@simmkyu simmkyu deleted the react-18 branch May 31, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devalevenkatesh devalevenkatesh devalevenkatesh approved these changes

@michhyun1 michhyun1 michhyun1 left review comments

@kdsbatra kdsbatra kdsbatra left review comments

@samspycher samspycher samspycher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xuesichao @samspycher @kdsbatra @michhyun1 @devalevenkatesh @simmkyu