Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

350 improvement serverless test workshop UI configuration improvement #351

Conversation

wtromano-aws
Copy link
Contributor

Issue #, if available: 350

Description of changes:

  • The application retrieves the backend API endpoint given the stack name in an environment variable name BACKEND_STACK_NAME (or defaults to urs-backend)
  • Removed the ECS container resources for the UI front end, as this functionality has moved into the workshop project.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@wtromano-aws wtromano-aws requested a review from dancfox as a code owner August 21, 2024 12:53
@wtromano-aws wtromano-aws requested a review from brnkrygs August 21, 2024 12:56
@wtromano-aws wtromano-aws added enhancement New feature or request python labels Aug 21, 2024
Copy link
Contributor

@brnkrygs brnkrygs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only thing that comes to mind for me would be to add some logging around which endpoint the app chooses (either the cloudformation output or the default).

@wtromano-aws wtromano-aws merged commit 778a716 into main Aug 21, 2024
1 check passed
@wtromano-aws wtromano-aws deleted the 350-improvement-serverless-test-workshop-ui-configuration-improvement branch August 21, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Serverless Test Workshop - UI Configuration Improvement
3 participants