Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(documentation): updated folder structure #274

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lesliedanielraj
Copy link
Collaborator

Issue #, if available: 246

Description of changes: Updating the folder structure and references of the solution for it to be picked up by serverless land.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@dhelper dhelper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make sure the overall documentation is still correct.
if you have rtime it looks like we have a few easy to fix comments on Setup.cs file but maybe some of them shows a bigger issue at stake (unused _tablename), if not drop me a line and I'll try to have a look once we merge the code



# Asynchronous Integration Test with Amazon Simple Queue Service (SQS)
You may use a variety of resource types to create the event listener for your asynchronous system under test ([more about event listeners](https://github.com/aws-samples/serverless-test-samples/tree/main/dotnet-test-samples/async-architectures#create-event-listeners-in-test-environments)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the end of the refactoring this folder would be removed, need to find a solution for the common artifacts and pages.
Perhaps keeping the old page is a good idea but needs to update https://github.com/aws-samples/serverless-test-samples/tree/main/dotnet-test-samples/async-architectures to point at this pattern as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are thos used in other async patterns? maybe move them to a common location such as https://github.com/aws-samples/serverless-test-samples/tree/main/dotnet-test-samples/docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants