Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Module terraform rework #864

Merged
merged 7 commits into from
Mar 22, 2024
Merged

chore: Module terraform rework #864

merged 7 commits into from
Mar 22, 2024

Conversation

niallthomson
Copy link
Contributor

What this PR does / why we need it:

Each lab can provide Terraform configuration to provision additional resources and customize the EKS cluster. This PR changes the way that Terraform is written so that it acts like a true module rather that copying the TF files.

The main change this involves is that the TF configurations no longer implicitly have access to the convenience local and var stuff like local.addon_context defined in base.tf. Instead each module accepts these as variables. This means that the Terraform can be properly validated by IDEs and formatting tools because each labs Terraform is a standalone TF module.

The reset-environment script has been modified to handle both the old style modules and these changes for now. The legacy code path will be removed in a future release.

Which issue(s) this PR fixes:

Fixes #

Quality checks

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@niallthomson niallthomson requested a review from a team as a code owner March 22, 2024 19:06
Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for eks-workshop ready!

Name Link
🔨 Latest commit d281a47
🔍 Latest deploy log https://app.netlify.com/sites/eks-workshop/deploys/65fdd6bb81e73500094df015
😎 Deploy Preview https://deploy-preview-864--eks-workshop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@niallthomson niallthomson merged commit 33eab94 into main Mar 22, 2024
7 checks passed
@niallthomson niallthomson deleted the module-terraform-rework branch March 22, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant