Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Each lab can provide Terraform configuration to provision additional resources and customize the EKS cluster. This PR changes the way that Terraform is written so that it acts like a true module rather that copying the TF files.
The main change this involves is that the TF configurations no longer implicitly have access to the convenience
local
andvar
stuff likelocal.addon_context
defined inbase.tf
. Instead each module accepts these as variables. This means that the Terraform can be properly validated by IDEs and formatting tools because each labs Terraform is a standalone TF module.The
reset-environment
script has been modified to handle both the old style modules and these changes for now. The legacy code path will be removed in a future release.Which issue(s) this PR fixes:
Fixes #
Quality checks
make test module="<module>"
it was successful (see https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.