Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock scratchstack-aws-signature to 0.10.5 #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RyanJarv
Copy link

@RyanJarv RyanJarv commented Sep 2, 2024

Building this crate, either in docker or locally, causes a mismatch of http::request::Parts types in src/xks_proxy/sigv4.rs:

    let sigv4_req = Sigv4Request::from_http_request_parts(&parts, body_as_vec_u8);
        |                     ------------------------------------- ^^^^^^ expected http::request::Parts, found a different http::request::Parts
        |                     |
        |                     arguments to this function are incorrect
        |
        = note: http::request::Parts and http::request::Parts have similar names, but are actually distinct types
    note: http::request::Parts is defined in crate http
       --> /Users/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/http-0.2.12/src/request.rs:166:1
        |
    166 | pub struct Parts {
        | ^^^^^^^^^^^^^^^^
    note: http::request::Parts is defined in crate http
       --> /Users/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/http-1.1.0/src/request.rs:168:1
        |
    168 | pub struct Parts {
        | ^^^^^^^^^^^^^^^^
        = note: perhaps two different versions of crate http are being used?
    note: associated function defined here
       --> /Users/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/scratchstack-aws-signature-0.10.6/src/signature.rs:762:12
        |
    762 |     pub fn from_http_request_parts(parts: &Parts, body: Option<Vec<u8>>) -> Self {
        |            ^^^^^^^^^^^^^^^^^^^^^^^

    For more information about this error, try rustc --explain E0308.
    error: could not compile xks-proxy (bin "xks-proxy") due to 1 previous error

I'm not super familiar with rust but it looks like this is caused by the http dependency of scratchstack-aws-signature being updated from ^0.2 to ^1.0 for the 0.10.6 release:

dacut/scratchstack-aws-signature@e77f615

Description of changes:

This just locks scratchstack-aws-signature to 0.10.5.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

The http dependency was updated to ^1.0 in 0.10.6:

  dacut/scratchstack-aws-signature@e77f615

Which causes a mismatch of http::request::Parts types in src/xks_proxy/sigv4.rs:

    let sigv4_req = Sigv4Request::from_http_request_parts(&parts, body_as_vec_u8);
        |                     ------------------------------------- ^^^^^^ expected http::request::Parts, found a different http::request::Parts
        |                     |
        |                     arguments to this function are incorrect
        |
        = note: http::request::Parts and http::request::Parts have similar names, but are actually distinct types
    note: http::request::Parts is defined in crate http
       --> /Users/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/http-0.2.12/src/request.rs:166:1
        |
    166 | pub struct Parts {
        | ^^^^^^^^^^^^^^^^
    note: http::request::Parts is defined in crate http
       --> /Users/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/http-1.1.0/src/request.rs:168:1
        |
    168 | pub struct Parts {
        | ^^^^^^^^^^^^^^^^
        = note: perhaps two different versions of crate http are being used?
    note: associated function defined here
       --> /Users/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/scratchstack-aws-signature-0.10.6/src/signature.rs:762:12
        |
    762 |     pub fn from_http_request_parts(parts: &Parts, body: Option<Vec<u8>>) -> Self {
        |            ^^^^^^^^^^^^^^^^^^^^^^^

    For more information about this error, try rustc --explain E0308.
    error: could not compile xks-proxy (bin "xks-proxy") due to 1 previous error
@RyanJarv RyanJarv mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant