-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat!: remove log4j #995
Closed
Closed
Feat!: remove log4j #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehouel
reviewed
Nov 22, 2022
...ogging-logback/src/main/java/software/amazon/lambda/powertools/logging/LambdaEcsEncoder.java
Show resolved
Hide resolved
jeromevdl
force-pushed
the
feat/remove_log4j
branch
from
November 22, 2022 22:21
b2855d8
to
fcfd91b
Compare
@pankajagrawal16 I'd like to get your thought on this one if you have some time. |
👍 I can give it a look sometime this week. |
jeromevdl
added
v2
Version 2
status/staged-major-release
This change will go with the next major release
RFC
and removed
RFC
labels
Feb 23, 2023
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-more-information
RFC
size/XXL
status/staged-major-release
This change will go with the next major release
v2
Version 2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #965
Description of changes:
Developer experience
The developer experience doesn't change that much. Instead of using the logging module, developers need to add the implementation module (logging-logback, logging-log4j, ...) which has a dependency on the logging module.
Ex:
Then they need to have the proper config file (log4j2.xml or logback.xml).
JsonTemplateLayout
. Two layout.json files are provided (standard and ECS). This can be extended. Developers can also choose to remove some fields generated by powertools or to rename them. The Resolver is more granular (each field is accessible). See the LambdaJsonLayout.json or LambdaEcsLaout.json.LambdaJsonEncoder
andLambdaEcsEncoder
). They don't rely on any external dependency (json, elastic) to reduce the size of the final package. We can probably go further in the customization here (for example having an 'excludeFields' attribute to remove some of the fields or an 'includeFields' to only select a few ones:Checklist
==> this version will not be backward compatible. Several changes are required from the developer, and it comes with several changes (field names)
==> but it comes with a more standard way of logging (slf4j) and does not force a specific framework. It is also a bit more open for extension.
==> not fully, wanted to share the DX first.
==> not yet, wanted to share the DX first.
Breaking changes
RFC issue #: #965, #752
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.