Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): Split powertools idempotency module (without redis impl) #1559

Merged
merged 13 commits into from
Feb 13, 2024

Conversation

scottgerring
Copy link
Contributor

@scottgerring scottgerring commented Feb 13, 2024

Issue #, if available:
#1504

Description of changes:

Takes @eldimi 's changes from #1513 for the module split only. I've rebased the commits from 0ec7f4a0d7424c24cb402f23f6896111f257ac44 to 6da6aaf6b558edb56b18dd71e2f0ed1a7a8d8d13 inclusive onto v2. We will merge this and take the redis implementation in later.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@scottgerring
Copy link
Contributor Author

It's not clear to me if v2 is broken or if there's something subtle in the changeset here that breaks the validation module. The build errors seem unrelated to the changeset.

@scottgerring scottgerring force-pushed the chore/v2-split-idempotency-mod-only branch 2 times, most recently from 801edf2 to 6f214c2 Compare February 13, 2024 13:44
Copy link

github-actions bot commented Feb 13, 2024

💾 Artifacts Size Report

Module Version Size (KB)
powertools-common 2.0.0-SNAPSHOT 9.59
powertools-serialization 2.0.0-SNAPSHOT 17.69
powertools-logging 2.0.0-SNAPSHOT 20.74
powertools-logging-log4j 2.0.0-SNAPSHOT 21.78
powertools-logging-logback 2.0.0-SNAPSHOT 20.19
powertools-tracing 2.0.0-SNAPSHOT 14.00
powertools-metrics 2.0.0-SNAPSHOT 14.05
powertools-parameters 2.0.0-SNAPSHOT 17.46
powertools-validation 2.0.0-SNAPSHOT 20.80
powertools-cloudformation 2.0.0-SNAPSHOT 16.99
powertools-idempotency-core 2.0.0-SNAPSHOT 35.55
powertools-idempotency-dynamodb 2.0.0-SNAPSHOT 12.90
powertools-large-messages 2.0.0-SNAPSHOT 17.45
powertools-batch 2.0.0-SNAPSHOT 16.89
powertools-parameters-ssm 2.0.0-SNAPSHOT 10.69
powertools-parameters-secrets 2.0.0-SNAPSHOT 9.90
powertools-parameters-dynamodb 2.0.0-SNAPSHOT 11.95
powertools-parameters-appconfig 2.0.0-SNAPSHOT 11.97

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v2@b0af349). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #1559   +/-   ##
=====================================
  Coverage      ?   89.79%           
  Complexity    ?      406           
=====================================
  Files         ?       44           
  Lines         ?     1274           
  Branches      ?      165           
=====================================
  Hits          ?     1144           
  Misses        ?       88           
  Partials      ?       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scottgerring scottgerring force-pushed the chore/v2-split-idempotency-mod-only branch 2 times, most recently from 478e790 to 6a3be41 Compare February 13, 2024 14:00
@scottgerring scottgerring force-pushed the chore/v2-split-idempotency-mod-only branch from 6a3be41 to f5928ec Compare February 13, 2024 14:17
Copy link

Quality Gate Passed Quality Gate passed

Issues
85 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@scottgerring scottgerring marked this pull request as ready for review February 13, 2024 14:50
@scottgerring scottgerring merged commit 82d4b30 into v2 Feb 13, 2024
13 checks passed
@scottgerring scottgerring deleted the chore/v2-split-idempotency-mod-only branch February 13, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants