Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: FIx Metrics - Add missing array to wrap metrics array #666

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Oct 9, 2024

Please provide the issue number

Issue number: #662

Summary

Changes

Add missing array that wraps Dimensions array

Empty Dimensions

{
  "_aws": {
    "Timestamp": 1728503062129,
    "CloudWatchMetrics": [
      {
        "Namespace": "dotnet-powertools-test",
        "Metrics": [
          {
            "Name": "Metric Name",
            "Unit": "Count"
          }
        ],
        "Dimensions": [
          []
        ]
      }
    ]
  },
  "Metric Name": 1
}

Dimensions with values

{
  "_aws": {
    "Timestamp": 1728503151889,
    "CloudWatchMetrics": [
      {
        "Namespace": "ns",
        "Metrics": [
          {
            "Name": "ColdStart",
            "Unit": "Count"
          }
        ],
        "Dimensions": [
          [
            "FunctionName",
            "Service"
          ]
        ]
      }
    ]
  },
  "FunctionName": "My Function with context",
  "Service": "svc",
  "ColdStart": 1
}

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested a review from amirkaws October 9, 2024 20:02
@boring-cyborg boring-cyborg bot added the area/metrics Core metrics utility label Oct 9, 2024
@auto-assign auto-assign bot requested a review from sliedig October 9, 2024 20:02
@boring-cyborg boring-cyborg bot added the tests label Oct 9, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 9, 2024
@github-actions github-actions bot added the internal Maintenance changes label Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.44%. Comparing base (5eb8338) to head (31dad3b).

Files with missing lines Patch % Lines
...aries/src/AWS.Lambda.Powertools.Metrics/Metrics.cs 77.77% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #666   +/-   ##
========================================
  Coverage    73.43%   73.44%           
========================================
  Files          196      196           
  Lines         8027     8043   +16     
  Branches       857      858    +1     
========================================
+ Hits          5895     5907   +12     
- Misses        1846     1849    +3     
- Partials       286      287    +1     
Flag Coverage Δ
unittests 73.44% <78.57%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 21, 2024
Copy link

sonarcloud bot commented Oct 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics Core metrics utility internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants