Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps):bump sdk dependency version to 1.17.2 #178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

muboheng
Copy link

Issue #, if available:

Description of changes:
bump sdk dependency version to public version: 1.17.2
Why is this change necessary:

How was this change tested:

Any additional information or context required to review the change:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@muboheng muboheng changed the title chore(dep):bump sdk dependency version to 1.17.2 chore(deps):bump sdk dependency version to 1.17.2 Oct 23, 2023
@@ -86,7 +86,7 @@
<dependency>
<groupId>software.amazon.awssdk.iotdevicesdk</groupId>
<artifactId>aws-iot-device-sdk</artifactId>
<version>1.17.0-CLUSTER-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CLI in development still needs cluster support. Could you create the release branch and cut a PR to release branch directly?

@github-actions
Copy link

Client Coverage Report

File Coverage Lines Branches
All files 63% 58% 68%
com.aws.greengrass.cli.module.AdapterModule 100% 100% 0%
com.aws.greengrass.cli.module.LogsModule 75% 75% 0%
com.aws.greengrass.cli.module.VersionProvider 13% 13% 0%
com.aws.greengrass.cli.util.FileUtils 0% 0% 0%
com.aws.greengrass.cli.util.FileUtils$1 0% 0% 0%
com.aws.greengrass.cli.util.PlatformUtils 0% 0% 0%
com.aws.greengrass.cli.adapter.impl.NucleusAdapterIpcClientImpl$SubscriptionMqttResponseHandler 0% 0% 0%
com.aws.greengrass.cli.adapter.impl.NucleusAdapterIpcClientImpl 6% 4% 9%
com.aws.greengrass.cli.adapter.impl.NucleusAdapterIpcClientImpl$SubscriptionResponseHandler 0% 0% 0%
com.aws.greengrass.cli.adapter.impl.NucleusAdapterIpcClientImpl$1 0% 0% 0%
com.aws.greengrass.cli.commands.topic.PubSubCommand 60% 71% 50%
com.aws.greengrass.cli.commands.topic.IotCoreCommand 60% 71% 50%
com.aws.greengrass.cli.commands.topic.TopicBaseInfo 59% 68% 50%
com.aws.greengrass.cli.CommandFactory 71% 71% 0%
com.aws.greengrass.cli.CLI 13% 13% 0%
com.aws.greengrass.cli.util.logs.LogFile 69% 80% 58%
com.aws.greengrass.cli.util.logs.FileReader 91% 85% 96%
com.aws.greengrass.cli.util.logs.LogsUtil 92% 92% 0%
com.aws.greengrass.cli.util.logs.LogEntry 91% 95% 87%
com.aws.greengrass.cli.util.logs.LogQueue 76% 85% 66%
com.aws.greengrass.cli.util.logs.impl.VisualizationImpl 89% 97% 81%
com.aws.greengrass.cli.util.logs.impl.FilterImpl 96% 100% 93%
com.aws.greengrass.cli.util.logs.impl.AggregationImpl 93% 98% 87%
com.aws.greengrass.cli.util.logs.impl.AggregationImplConfig 93% 93% 0%
com.aws.greengrass.cli.util.logs.impl.FilterImpl$FilterEntry 100% 100% 0%
com.aws.greengrass.cli.commands.PasswordCommand 16% 16% 0%
com.aws.greengrass.cli.commands.Logs 98% 96% 100%
com.aws.greengrass.cli.commands.BaseCommand 20% 20% 0%
com.aws.greengrass.cli.commands.ComponentCommand 100% 100% 100%
com.aws.greengrass.cli.commands.DeploymentCommand 51% 56% 47%

Minimum allowed coverage is 65%

Generated by 🐒 cobertura-action against 4af2ef4

@github-actions
Copy link

Server Coverage Report

File Coverage Lines Branches
All files 70% 89% 52%
com.aws.greengrass.cli.CLIEventStreamAgent 87% 94% 80%
com.aws.greengrass.cli.CLIEventStreamAgent$ListLocalDeploymentsHandler 73% 96% 50%
com.aws.greengrass.cli.CLIEventStreamAgent$RestartComponentsHandler 98% 96% 100%
com.aws.greengrass.cli.CLIEventStreamAgent$CreateDebugPasswordHandler 91% 91% 0%
com.aws.greengrass.cli.CLIEventStreamAgent$CreateLocalDeploymentHandler 82% 84% 80%
com.aws.greengrass.cli.CLIEventStreamAgent$GetLocalDeploymentStatusHandler 91% 96% 85%
com.aws.greengrass.cli.CLIEventStreamAgent$StopComponentHandler 96% 96% 0%
com.aws.greengrass.cli.CLIService$LocalDeploymentDetails 0% 0% 0%
com.aws.greengrass.cli.CLIEventStreamAgent$ListComponentsHandler 97% 94% 100%
com.aws.greengrass.cli.CLIEventStreamAgent$LocalDeploymentDetails 76% 76% 0%
com.aws.greengrass.cli.CLIEventStreamAgent$GetComponentDetailsHandler 96% 96% 0%
com.aws.greengrass.cli.CLIEventStreamAgent$CancelLocalDeploymentHandler 76% 85% 66%
com.aws.greengrass.cli.CLIService 75% 85% 65%

Minimum allowed coverage is 58%

Generated by 🐒 cobertura-action against 4af2ef4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants