catch common resource schema issues in cfn validate #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
continuing #663 readOnlyProperties overlapping with required: AWS::CodeArtifact::Repository.DomainName AWS::MWAA::Environment.Name
PatMyron
requested review from
wbingli,
johnttompkins,
ammokhov,
priyap286 and
omkhegde
sungkkim
approved these changes
Jan 20, 2021
Yeah, that's why I didn't commit it, but I manually tested with this resource schema: {
"typeName" : "AWS::Service::Type",
"description" : "",
"additionalProperties" : false,
"properties" : {
"Property" : {
"type" : "string"
}
},
"readOnlyProperties": [
"/properties/Property"
],
"required": [
"Property"
],
"primaryIdentifier" : [ "/properties/Property" ]
}readOnlyProperties cannot be specified by customers and should not overlap with writeOnlyProperties, createOnlyProperties, or required: {'/properties/Property'} |
johnttompkins
approved these changes
Jan 21, 2021
PatMyron
changed the title
This was referenced Jan 28, 2021
PatMyron
commented
Jun 3, 2021
| ) & ( | ||
| set(resource_spec.get("createOnlyProperties", [])) | ||
| | set(resource_spec.get("writeOnlyProperties", [])) | ||
| | {"/properties/" + s for s in resource_spec.get("required", [])} |
There was a problem hiding this comment.
think this wouldn't catch nested required properties overlapping with readOnlyProperties
6 tasks
kddejong
pushed a commit
to kddejong/cloudformation-cli
that referenced
this pull request
Oct 24, 2022
continuing aws-cloudformation#663 readOnlyProperties overlapping with required: AWS::CodeArtifact::Repository.DomainName AWS::MWAA::Environment.Name
kddejong
pushed a commit
to kddejong/cloudformation-cli
that referenced
this pull request
Oct 24, 2022
continuing aws-cloudformation#663 readOnlyProperties overlapping with required: AWS::CodeArtifact::Repository.DomainName AWS::MWAA::Environment.Name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuing #663
readOnlyProperties overlapping with required:AWS::CodeArtifact::Repository.DomainNameAWS::MWAA::Environment.Namehow to run new validations on all existing resource provider schemas