catch common resource schema issues in cfn validate

encouraging explicit boolean values instead of defaults
aws-cloudformation · Jun 22, 2021 · d4ee256 · d4ee256
1 parent 629ea86
commit d4ee256
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/src/rpdk/core/data_loaders.py b/src/rpdk/core/data_loaders.py
@@ -156,6 +156,14 @@ def load_resource_spec(resource_spec_file):  # pylint: disable=R # noqa: C901
                 try:
                     property_type = property_details["type"]
                     property_keywords = property_details.keys()
+                    if (
+                        property_type == "array"
+                        and "insertionOrder" not in property_keywords
+                    ):
+                        LOG.warning(
+                            "Explicitly specify value for insertionOrder for array: %s",
+                            property_name,
+                        )
                     keyword_mappings = [
                         (
                             {"integer", "number"},
@@ -316,6 +324,9 @@ def load_resource_spec(resource_spec_file):  # pylint: disable=R # noqa: C901
             "readOnlyProperties and conditionalCreateOnlyProperties MUST NOT have common properties"
         )
 
+    if "taggable" not in resource_spec:
+        LOG.warning("Explicitly specify value for taggable")
+
     # TODO: more general validation framework
     if "remote" in resource_spec:
         raise SpecValidationError(