test resource schemas with common issue warnings

aws-cloudformation · Jan 28, 2021 · 8955e66 · 8955e66
1 parent 8fb40f2
commit 8955e66
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/src/rpdk/core/data_loaders.py b/src/rpdk/core/data_loaders.py
@@ -157,8 +157,8 @@ def load_resource_spec(resource_spec_file):  # pylint: disable=R0912 # noqa: C90
     for enum in nested_lookup("enum", resource_spec):
         if len(enum) > 15:
             LOG.warning(
-                "Consider not manually maintaining large constantly evolving enums like ",
-                "instance types, lambda runtimes, partitions, regions, availability zones, etc. that get outdated quickly: %s",
+                "Consider not manually maintaining large constantly evolving enums like"
+                + "instance types, lambda runtimes, partitions, regions, availability zones, etc. that get outdated quickly: %s",
                 enum,
             )
 

diff --git a/tests/data/schema/valid/invalid_property_constraints.json b/tests/data/schema/valid/invalid_property_constraints.json
@@ -0,0 +1,16 @@
+{
+  "typeName" : "AWS::Service::Type",
+  "description" : "",
+  "additionalProperties" : false,
+  "properties" : {
+    "Property" : {
+      "type" : "string",
+      "pattern" : "arn:aws:[A-Za-z0-9]+{1,255}",
+      "enum" : [ "a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l", "m", "n", "o", "p", "q", "r", "s", "t", "u", "v", "w", "x", "y", "z"  ]
+    }
+  },
+  "readOnlyProperties": [
+    "/properties/Property"
+  ],
+  "primaryIdentifier" : [ "/properties/Property" ]
+}