Adding resource type for VS Code Remote Development #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| "devDependencies": { | ||
| "@types/node": "^12.19.16", | ||
| "typescript": "^3.8.3" |
There was a problem hiding this comment.
I would use typescript v4+ (it does not matter now, but the model generation might need in the future)
| "@aws-cdk/aws-iam": "1.58.0", | ||
| "@aws-cdk/core": "1.58.0", | ||
| "@types/uuid": "^8.3.0", | ||
| "cfn-rpdk": "https://github.com/eduardomourar/cloudformation-cli-typescript-plugin/releases/download/v0.5.0/cfn-rpdk-0.5.0.tgz", |
There was a problem hiding this comment.
The GA version should be used here: https://www.npmjs.com/package/@amazon-web-services-cloudformation/cloudformation-cli-typescript-lib
craigataws
reviewed
Apr 29, 2021
PatMyron
reviewed
Oct 22, 2021
| "handlers": { | ||
| "create": { | ||
| "permissions": [ | ||
| "*" |
There was a problem hiding this comment.
| "description": "The EC2 Instance Type of developer instance. You can only select instance types that support hibernation", | ||
| "type": "string", | ||
| "default": "m4.xlarge", | ||
| "enum": ["c4.large", "c4.xlarge", "c4.2xlarge", "c4.4xlarge", "c4.8xlarge", "c5.large", "c5.xlarge", "c5.2xlarge", "c5.4xlarge", |
There was a problem hiding this comment.
There was a problem hiding this comment.
@PatMyron I'd remove the enum. Is it sensible to keep the default, or would you remove this as well, as it could be invalid at some point in the future?
|
@PatMyron thanks for picking this up, working on it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Submitting a new resource type as discussed with @craigataws
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.