Add SageMaker Domain, UserProfile, App and AppImageConfig resources #7
Conversation
- add AWS::SageMaker::Domain CloudFormation resource type - add AWS::SageMaker::UserProfile CloudFormation resource type - add AWS::SageMaker::App CloudFormation resource type - add AWS::SageMaker::AppImageConfig CloudFormation resource type - update repo README to reflect new resource types
| "InstanceType": { | ||
| "type": "string", | ||
| "description": "The instance type that the image version runs on.", | ||
| "enum": [ |
There was a problem hiding this comment.
Consider not manually maintaining large constantly evolving enums like instance types that get outdated quickly:
https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-gamelift/pull/6#discussion_r416176707
(caught by running cfn validate)
only leaving one comment but applies to all these files:
aws-sagemaker-app.json
aws-sagemaker-domain.json
aws-sagemaker-userprofile.json
There was a problem hiding this comment.
Hey @PatMyron, good suggestion. I think for now, I've followed the corresponding API values: https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_ResourceSpec.html#sagemaker-Type-ResourceSpec-InstanceType.
However it is a good idea to use regex instead of an enum. Will keep track of this internally. LL-5330
Issue #, if available:
Description of changes:
References:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.