add sagemaker resource types #2
Conversation
jerrypeng7773
changed the title
| - "sagemaker:ListProjects" | ||
| - "sagemaker:ListTags" | ||
| - "servicecatalog:DescribeProduct" | ||
| - "servicecatalog:DescribeProvisioningArtifact" |
There was a problem hiding this comment.
Does not contain the latest changes ; minor diff with https://code.amazon.com/packages/AWSCloudFormationResourceProvidersSageMaker/trees/heads/repositoryservice-github-backup
| @@ -0,0 +1,132 @@ | |||
| { | |||
There was a problem hiding this comment.
Minor diff from the latest - Updated repositoryservice-github-backup; Please take the latest from https://code.amazon.com/packages/AWSCloudFormationResourceProvidersSageMaker/logs/repositoryservice-github-backup
| @@ -0,0 +1,136 @@ | |||
| { | |||
| "typeName": "AWS::SageMaker::Pipeline", | |||
There was a problem hiding this comment.
aws-sagemaker-modelqualityjobdefinition/aws-sagemaker-modelqualityjobdefinition.json
Show resolved
Hide resolved
...gemaker-modelexplainabilityjobdefinition/aws-sagemaker-modelexplainabilityjobdefinition.json
Show resolved
Hide resolved
aws-sagemaker-modelbiasjobdefinition/aws-sagemaker-modelbiasjobdefinition.json
Show resolved
Hide resolved
aws-sagemaker-dataqualityjobdefinition/aws-sagemaker-dataqualityjobdefinition.json
Show resolved
Hide resolved
|
project, model-pacakge-group, and pipeline needs to sync up the mainline branch and the github-backup-branch. |
| "permissions": [ | ||
| "sagemaker:DescribeModelPackageGroup", | ||
| "sagemaker:GetModelPackageGroupPolicy", | ||
| "sagemaker:PutModelPackageGroupPolicy", |
There was a problem hiding this comment.
PutModelPackageGroupPolicy may not be required here in read block.
| } | ||
|
|
||
| /** | ||
| * This is used to ensure model package group resource has moved from Pending to Scheduled/Failed state. |
There was a problem hiding this comment.
don't think so, this probably is copied from monitoring schedule.
|
I'll squash and merge, and open another PR to address that bad comments |
| "type" : "string", | ||
| "minimum" : 1, | ||
| "maximum" : 2048 |
There was a problem hiding this comment.
aws-cloudformation/cloudformation-cli#414
https://json-schema.org/understanding-json-schema/reference/string.html#length
| "type" : "string", | |
| "minimum" : 1, | |
| "maximum" : 2048 | |
| "type" : "string", | |
| "minLength" : 1, | |
| "maxLength" : 2048 |
| "type" : "string", | ||
| "minimum" : 1, | ||
| "maximum" : 2048 |
There was a problem hiding this comment.
aws-cloudformation/cloudformation-cli#414
https://json-schema.org/understanding-json-schema/reference/string.html#length
| "type" : "string", | |
| "minimum" : 1, | |
| "maximum" : 2048 | |
| "type" : "string", | |
| "minLength" : 1, | |
| "maxLength" : 2048 |
...gemaker-modelexplainabilityjobdefinition/aws-sagemaker-modelexplainabilityjobdefinition.json
Show resolved
Hide resolved
| "type" : "string", | ||
| "minimum" : 1, | ||
| "maximum" : 2048 |
There was a problem hiding this comment.
aws-cloudformation/cloudformation-cli#414
https://json-schema.org/understanding-json-schema/reference/string.html#length
| "type" : "string", | |
| "minimum" : 1, | |
| "maximum" : 2048 | |
| "type" : "string", | |
| "minLength" : 1, | |
| "maxLength" : 2048 |
There was a problem hiding this comment.
thanks for catching this up, will fix in a new PR
| "type" : "string", | ||
| "minimum" : 1, | ||
| "maximum" : 2048 |
There was a problem hiding this comment.
aws-cloudformation/cloudformation-cli#414
https://json-schema.org/understanding-json-schema/reference/string.html#length
| "type" : "string", | |
| "minimum" : 1, | |
| "maximum" : 2048 | |
| "type" : "string", | |
| "minLength" : 1, | |
| "maxLength" : 2048 |
| "type" : "array", | ||
| "description" : "Monitoring outputs for monitoring jobs. This is where the output of the periodic monitoring jobs is uploaded.", | ||
| "minLength" : 1, | ||
| "maxLength" : 1, |
There was a problem hiding this comment.
don't think minLength/maxLength can be applied to array types:
aws-cloudformation/cloudformation-cli#414
https://json-schema.org/understanding-json-schema/reference/array.html#length
| "type" : "array", | ||
| "description" : "Monitoring outputs for monitoring jobs. This is where the output of the periodic monitoring jobs is uploaded.", | ||
| "minLength" : 1, | ||
| "maxLength" : 1, |
There was a problem hiding this comment.
don't think minLength/maxLength can be applied to array types:
aws-cloudformation/cloudformation-cli#414
https://json-schema.org/understanding-json-schema/reference/array.html#length
| "type" : "array", | ||
| "description" : "Monitoring outputs for monitoring jobs. This is where the output of the periodic monitoring jobs is uploaded.", | ||
| "minLength" : 1, | ||
| "maxLength" : 1, |
There was a problem hiding this comment.
don't think minLength/maxLength can be applied to array types:
aws-cloudformation/cloudformation-cli#414
https://json-schema.org/understanding-json-schema/reference/array.html#length
| "type" : "array", | ||
| "description" : "Monitoring outputs for monitoring jobs. This is where the output of the periodic monitoring jobs is uploaded.", | ||
| "minLength" : 1, | ||
| "maxLength" : 1, |
There was a problem hiding this comment.
don't think minLength/maxLength can be applied to array types:
aws-cloudformation/cloudformation-cli#414
https://json-schema.org/understanding-json-schema/reference/array.html#length
| "type" : "array", | ||
| "description" : "Monitoring outputs for monitoring jobs. This is where the output of the periodic monitoring jobs is uploaded.", | ||
| "minLength" : 1, | ||
| "maxLength" : 1, |
There was a problem hiding this comment.
don't think minLength/maxLength can be applied to array types:
aws-cloudformation/cloudformation-cli#414
https://json-schema.org/understanding-json-schema/reference/array.html#length
| }, | ||
| "list": { | ||
| "permissions": [ | ||
| "sagemaker:ListMonitoringSchedule" |
There was a problem hiding this comment.
| "sagemaker:ListMonitoringSchedule" | |
| "sagemaker:ListMonitoringSchedules" |
https://docs.aws.amazon.com/service-authorization/latest/reference/list_amazonsagemaker.html
Issue #, if available:
Description of changes:
add aws-sagemaker-pipeline resource type.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.