-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move duplicate handler code to super class (#13)
* Add ListHandler with UnitTests * Move duplicate handler code into super class
- Loading branch information
Showing
6 changed files
with
93 additions
and
215 deletions.
There are no files selected for viewing
74 changes: 74 additions & 0 deletions
74
...workscm-server/src/main/java/software/amazon/opsworkscm/server/BaseOpsWorksCMHandler.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| package software.amazon.opsworkscm.server; | ||
|
|
||
| import com.amazonaws.util.StringUtils; | ||
| import software.amazon.awssdk.services.opsworkscm.OpsWorksCmClient; | ||
| import software.amazon.cloudformation.proxy.AmazonWebServicesClientProxy; | ||
| import software.amazon.cloudformation.proxy.Logger; | ||
| import software.amazon.cloudformation.proxy.ProgressEvent; | ||
| import software.amazon.cloudformation.proxy.ResourceHandlerRequest; | ||
| import software.amazon.cloudformation.resource.IdentifierUtils; | ||
|
|
||
| abstract public class BaseOpsWorksCMHandler extends BaseHandler<CallbackContext> { | ||
|
|
||
|
|
||
| protected ResourceModel model; | ||
| protected ResourceModel oldModel; | ||
| protected CallbackContext callbackContext; | ||
| protected Logger logger; | ||
| protected ResourceHandlerRequest<ResourceModel> request; | ||
| protected ClientWrapper client; | ||
|
|
||
| protected static int NO_CALLBACK_DELAY = 0; | ||
| protected static int CALLBACK_DELAY_SECONDS = 60; | ||
| private static final int MAX_LENGTH_CONFIGURATION_SET_NAME = 40; | ||
|
|
||
| @Override | ||
| abstract public ProgressEvent<ResourceModel, CallbackContext> handleRequest( | ||
| final AmazonWebServicesClientProxy proxy, | ||
| final ResourceHandlerRequest<ResourceModel> request, | ||
| final CallbackContext callbackContext, | ||
| final Logger logger); | ||
|
|
||
| protected void initialize(final AmazonWebServicesClientProxy proxy, | ||
| final ResourceHandlerRequest<ResourceModel> request, | ||
| final CallbackContext callbackContext, | ||
| final Logger logger) { | ||
| this.request = request; | ||
| this.model = request.getDesiredResourceState(); | ||
| this.oldModel = request.getPreviousResourceState(); | ||
| this.callbackContext = callbackContext; | ||
| this.logger = logger; | ||
|
|
||
| setModelServerName(); | ||
| setModelId(); | ||
|
|
||
| final OpsWorksCmClient opsWorksCmClientclient = ClientBuilder.getClient(); | ||
| this.client = new ClientWrapper(opsWorksCmClientclient, model, oldModel, proxy, logger); | ||
| } | ||
|
|
||
| private void setModelServerName() { | ||
| if (StringUtils.isNullOrEmpty(model.getServerName())) { | ||
| logger.log("RequestModel doesn't have the server name. Setting it using request identifier and client token"); | ||
| model.setServerName( | ||
| IdentifierUtils.generateResourceIdentifier( | ||
| request.getLogicalResourceIdentifier(), | ||
| request.getClientRequestToken(), | ||
| MAX_LENGTH_CONFIGURATION_SET_NAME | ||
| ) | ||
| ); | ||
| } else if (model.getServerName().length() > MAX_LENGTH_CONFIGURATION_SET_NAME) { | ||
| logger.log(String.format("ServerName length was greater than %d characters. Truncating the ServerName", MAX_LENGTH_CONFIGURATION_SET_NAME)); | ||
| model.setServerName(model.getServerName().substring(0, MAX_LENGTH_CONFIGURATION_SET_NAME)); | ||
| } | ||
| } | ||
|
|
||
| private void setModelId() { | ||
| if (model.getId() == null) { | ||
| logger.log("RequestModel doesn't have the model id. Setting it using request identifier and client token"); | ||
| model.setId(IdentifierUtils.generateResourceIdentifier( | ||
| request.getLogicalResourceIdentifier(), | ||
| request.getClientRequestToken() | ||
| )); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.