Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json regex #16

Merged
merged 2 commits into from
May 14, 2020
Merged

Conversation

jiaminqin
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jiaminqin jiaminqin requested a review from chaochenq May 14, 2020 19:04
@@ -145,22 +185,33 @@
"$ref": "#/definitions/EncryptionConfiguration"
},
"ErrorOutputPrefix": {
"type": "string"
"type": "string",
"minimum": 1,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our model suggests 0 as min

},
"Prefix": {
"type": "string"
"type": "string",
"minimum": 1,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our model suggests 0 as min

},
"EncryptionConfiguration": {
"$ref": "#/definitions/EncryptionConfiguration"
},
"ErrorOutputPrefix": {
"type": "string"
"type": "string",
"minimum": 1,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

},
"Prefix": {
"type": "string"
"type": "string",
"minimum": 1,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

},
"DataTableName": {
"type": "string"
"type": "string",
"minimum": 0,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our model suggests 1 as min

@jiaminqin jiaminqin requested a review from kevincdeng May 14, 2020 19:31
@jiaminqin jiaminqin merged commit 7a904fb into aws-cloudformation:master May 14, 2020
@jiaminqin jiaminqin deleted the modelRestriction branch May 14, 2020 19:40
@PatMyron
Copy link

PatMyron commented Jul 24, 2020

Shouldn't the string length constraints be minLength and maxLength instead of minimum and maximum?

https://json-schema.org/understanding-json-schema/reference/string.html#length
aws-cloudformation/cloudformation-cli#414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants