Added Support for GoogleDrive DataSources #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for creating, updating, and deleting GoogleDrive data sources.
angranamzn
approved these changes
Jan 7, 2021
EricCeres
approved these changes
Jan 8, 2021
PatMyron
reviewed
Jan 28, 2021
Comment on lines
+1065
to
+1093
| "type": "array", | ||
| "minLength": 0, | ||
| "maxLength": 30, | ||
| "items": { | ||
| "$ref": "#/definitions/MimeType" | ||
| } | ||
| }, | ||
| "MimeType": { | ||
| "type": "string", | ||
| "minLength": 1, | ||
| "maxLength": 256 | ||
| }, | ||
| "ExcludeUserAccountsList": { | ||
| "type": "array", | ||
| "minLength": 0, | ||
| "maxLength": 100, | ||
| "items": { | ||
| "$ref": "#/definitions/UserAccount" | ||
| } | ||
| }, | ||
| "UserAccount": { | ||
| "type": "string", | ||
| "minLength": 1, | ||
| "maxLength": 256 | ||
| }, | ||
| "ExcludeSharedDrivesList": { | ||
| "type": "array", | ||
| "minLength": 0, | ||
| "maxLength": 100, |
There was a problem hiding this comment.
don't think minLength/maxLength can be applied to array types:
aws-cloudformation/cloudformation-cli#414
https://json-schema.org/understanding-json-schema/reference/array.html#length
(more spots in this file from other PRs as well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for creating, updating, and deleting
GoogleDrive data sources.
Issue #, if available:
none
Description of changes:
GoogleDriveConfigurationin the model fileGoogleDriveConverterTranslatorto utilize theGoogleDriveConverterfor google drive data sourcesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.