Feature/revert template converter #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 27, 2023 07:45
This reverts commit a282213
This reverts commit a282213. # Conflicts: # aws-kendra-datasource/src/main/java/software/amazon/kendra/datasource/Translator.java # aws-kendra-datasource/src/main/java/software/amazon/kendra/datasource/convert/TemplateConverter.java # aws-kendra-datasource/src/main/java/software/amazon/kendra/datasource/utils/DocumentTypeAdapter.java # aws-kendra-datasource/src/test/java/software/amazon/kendra/datasource/TranslatorTest.java # aws-kendra-datasource/src/test/java/software/amazon/kendra/datasource/convert/TemplateConverterTest.java # aws-kendra-datasource/testdata/datasourceconfiguration/valid_datasource_configuration.json
tzamazon
approved these changes
Sep 29, 2023
jregistr
approved these changes
Sep 30, 2023
WinterYukky
added a commit
to WinterYukky/aws-cloudformation-resource-providers-kendra
that referenced
this pull request
Oct 31, 2023
This reverts commit 52e4d9d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Template Converter didn't work properly
Description of changes:
Revert Template Converter
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.