Onboard AWS Glue DataBrew Resources to CloudFormation. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatMyron
reviewed
Jan 15, 2021
Comment on lines
+9
to
+30
| "pattern": "[ -\ud7ff\ue000-\ufffd\ud800\udc00-\udbff\udfff\t]*", | ||
| "minLength": 1, | ||
| "maxLength": 255 | ||
| }, | ||
| "EncryptionKeyArn": { | ||
| "description": "Encryption Key Arn", | ||
| "type": "string", | ||
| "minLength": 20, | ||
| "maxLength": 2048 | ||
| }, | ||
| "EncryptionMode": { | ||
| "description": "Encryption mode", | ||
| "enum": [ | ||
| "SSE-KMS", | ||
| "SSE-S3" | ||
| ], | ||
| "type": "string" | ||
| }, | ||
| "Name": { | ||
| "description": "Job name", | ||
| "type": "string", | ||
| "pattern": "[ -\ud7ff\ue000-\ufffd\ud800\udc00-\udbff\udfff\t]*", |
There was a problem hiding this comment.
What are these patterns trying to represent?
We're having issues with these non-ASCII patterns in aws-cloudformation/cfn-lint#1867
Let's get rid of these non-ASCII characters:
brew install coreutils
ggrep --color='auto' -P -n "[^\x00-\x7F]" aws-databrew-*
aws-databrew-job.json:9: "pattern" : "[ --�𐀀-�\t]*",
aws-databrew-job.json:27: "pattern" : "[ --�𐀀-�\t]*",
aws-databrew-job.json:72: "pattern" : "[ --�𐀀-�\t]*",
aws-databrew-recipe.json:8: "pattern" : "[ --�𐀀-�\t]*",
aws-databrew-recipe.json:16: "pattern" : "^[ -.0-^`--�]*$",
aws-databrew-schedule.json:37: "pattern" : "[ --�𐀀-�\t]*",
PatMyron
reviewed
Feb 6, 2021
| }, | ||
| "read": { | ||
| "permissions": [ | ||
| "databrew:ReadProject", |
There was a problem hiding this comment.
Suggested change
| "databrew:ReadProject", | |
| "databrew:DescribeProject", |
https://docs.aws.amazon.com/service-authorization/latest/reference/list_awsgluedatabrew.html
PatMyron
reviewed
May 12, 2021
| "TargetColumn" | ||
| ] | ||
| }, | ||
| "RecipeParameters": { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Onboard AWS Glue DataBrew Resources to CloudFormation.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.