Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding FlowDefinition to PutIntegration #12

Merged
merged 7 commits into from
May 5, 2021

Conversation

will-hodge
Copy link
Contributor

Description of changes:
Bringing our integration resource schema and CreateHandler up to date with recent PutIntegration API changes. This adds the FlowDefinition parameter.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@will-hodge will-hodge self-assigned this Apr 30, 2021
Copy link
Contributor

@lanxin-zhang-work lanxin-zhang-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@will-hodge will-hodge merged commit 09f628d into aws-cloudformation:main May 5, 2021
Comment on lines +28 to +31
"type": "string",
"maxLength": 512,
"pattern": "\\S+",
"additionalProperties": false
Copy link

@PatMyron PatMyron May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionalProperties is specifically a keyword for object types: aws-cloudformation/cloudformation-cli#729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants