Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial AWS AuditManager cloudformation support #2

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Initial AWS AuditManager cloudformation support #2

merged 3 commits into from
Dec 10, 2020

Conversation

itsmanishagarwal
Copy link
Contributor

Issue #, if available:

Description of changes:
IInitial AWS AuditManager cloudformation support

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@itsmanishagarwal itsmanishagarwal merged commit e102dfa into aws-cloudformation:master Dec 10, 2020
PatMyron
PatMyron reviewed Jan 8, 2021
View reviewed changes
aws-auditmanager-assessment/aws-auditmanager-assessment.json
"/properties/arn",
"/properties/creationTime",
"/properties/delegations",
"/properties/frameworkId"
Copy link

@PatMyron PatMyron Jan 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readOnlyProperties cannot be specified by the customer

Suggested change
"/properties/frameworkId"

https://docs.aws.amazon.com/cli/latest/reference/auditmanager/create-assessment.html

track aws-cloudformation/cloudformation-coverage-roadmap#68 for GetAtt support beyond readOnlyProperties

PatMyron added a commit to aws-cloudformation/cloudformation-cli that referenced this pull request Jan 8, 2021
@PatMyron
catch common resource schema issues
57fd2a3 
aws-cloudformation/aws-cloudformation-resource-providers-licensemanager#3
aws-cloudformation/aws-cloudformation-resource-providers-iotwireless#3
aws-cloudformation/aws-cloudformation-resource-providers-ssm#75

aws-cloudformation/aws-cloudformation-resource-providers-auditmanager#2
aws-cloudformation/aws-cloudformation-resource-providers-codeartifact#38
@PatMyron PatMyron mentioned this pull request Jan 8, 2021
Merged
PatMyron added a commit to aws-cloudformation/cloudformation-cli that referenced this pull request Jan 8, 2021
@PatMyron
catch common resource schema issues
c2c7cbb 
aws-cloudformation/aws-cloudformation-resource-providers-licensemanager#3
aws-cloudformation/aws-cloudformation-resource-providers-iotwireless#3
aws-cloudformation/aws-cloudformation-resource-providers-ssm#75

aws-cloudformation/aws-cloudformation-resource-providers-auditmanager#2
aws-cloudformation/aws-cloudformation-resource-providers-codeartifact#38
PatMyron added a commit to aws-cloudformation/cloudformation-cli that referenced this pull request Jan 8, 2021
@PatMyron
catch common resource schema issues
4d1e326 
aws-cloudformation/aws-cloudformation-resource-providers-licensemanager#3
aws-cloudformation/aws-cloudformation-resource-providers-iotwireless#3
aws-cloudformation/aws-cloudformation-resource-providers-ssm#75

aws-cloudformation/aws-cloudformation-resource-providers-auditmanager#2
aws-cloudformation/aws-cloudformation-resource-providers-codeartifact#38
PatMyron added a commit to aws-cloudformation/cloudformation-cli that referenced this pull request Jan 8, 2021
@PatMyron
catch common resource schema issues
39f56af 
aws-cloudformation/aws-cloudformation-resource-providers-licensemanager#3
aws-cloudformation/aws-cloudformation-resource-providers-iotwireless#3
aws-cloudformation/aws-cloudformation-resource-providers-ssm#75

aws-cloudformation/aws-cloudformation-resource-providers-auditmanager#2
aws-cloudformation/aws-cloudformation-resource-providers-codeartifact#38
PatMyron added a commit to aws-cloudformation/cloudformation-cli that referenced this pull request Jan 13, 2021
@PatMyron
catch common resource schema issues
394a0d4 
aws-cloudformation/aws-cloudformation-resource-providers-licensemanager#3
aws-cloudformation/aws-cloudformation-resource-providers-iotwireless#3
aws-cloudformation/aws-cloudformation-resource-providers-ssm#75

aws-cloudformation/aws-cloudformation-resource-providers-auditmanager#2
aws-cloudformation/aws-cloudformation-resource-providers-codeartifact#38
PatMyron added a commit to aws-cloudformation/cloudformation-cli that referenced this pull request Jan 13, 2021
@PatMyron
catch common resource schema issues
3828495 
aws-cloudformation/aws-cloudformation-resource-providers-licensemanager#3
aws-cloudformation/aws-cloudformation-resource-providers-iotwireless#3
aws-cloudformation/aws-cloudformation-resource-providers-ssm#75

aws-cloudformation/aws-cloudformation-resource-providers-auditmanager#2
aws-cloudformation/aws-cloudformation-resource-providers-codeartifact#38
PatMyron added a commit to aws-cloudformation/cloudformation-cli that referenced this pull request Jan 14, 2021
@PatMyron
catch common resource schema issues
c7eead2 
resource types with LIST API options like MaxResults, NextToken, Filters, etc as properties of the resource itself:
aws-cloudformation/aws-cloudformation-resource-providers-licensemanager#3
aws-cloudformation/aws-cloudformation-resource-providers-iotwireless#3
aws-cloudformation/aws-cloudformation-resource-providers-ssm#75

readOnlyProperties overlapping with writeOnlyProperties or createOnlyProperties:
aws-cloudformation/aws-cloudformation-resource-providers-auditmanager#2
aws-cloudformation/aws-cloudformation-resource-providers-codeartifact#38
PatMyron added a commit to aws-cloudformation/cloudformation-cli that referenced this pull request Jan 20, 2021
@PatMyron
catch common resource schema issues (#663)
197b3b1 
resource types with LIST API options like MaxResults, NextToken, Filters, etc as properties of the resource itself:
aws-cloudformation/aws-cloudformation-resource-providers-licensemanager#3
aws-cloudformation/aws-cloudformation-resource-providers-iotwireless#3
aws-cloudformation/aws-cloudformation-resource-providers-ssm#75

readOnlyProperties overlapping with writeOnlyProperties or createOnlyProperties:
aws-cloudformation/aws-cloudformation-resource-providers-auditmanager#2
aws-cloudformation/aws-cloudformation-resource-providers-codeartifact#38

no wildcards in handler permissions:
aws-cloudformation/aws-cloudformation-resource-providers-greengrassv2#4
aws-cloudformation/aws-cloudformation-resource-providers-imagebuilder@55fa9bf#r46035310
PatMyron
PatMyron reviewed Jan 28, 2021
View reviewed changes
aws-auditmanager-assessment/aws-auditmanager-assessment.json
Comment on lines +65 to +67
"type": "number",
"maxLength": 50,
"minLength": 47,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think minLength/maxLength can be applied to number types:
aws-cloudformation/cloudformation-cli#414
https://json-schema.org/understanding-json-schema/reference/numeric.html#range

@PatMyron PatMyron mentioned this pull request Jan 28, 2021
Closed
kddejong pushed a commit to kddejong/cloudformation-cli that referenced this pull request Oct 24, 2022
@PatMyron @kddejong
catch common resource schema issues (aws-cloudformation#663)
772abe2 
resource types with LIST API options like MaxResults, NextToken, Filters, etc as properties of the resource itself:
aws-cloudformation/aws-cloudformation-resource-providers-licensemanager#3
aws-cloudformation/aws-cloudformation-resource-providers-iotwireless#3
aws-cloudformation/aws-cloudformation-resource-providers-ssm#75

readOnlyProperties overlapping with writeOnlyProperties or createOnlyProperties:
aws-cloudformation/aws-cloudformation-resource-providers-auditmanager#2
aws-cloudformation/aws-cloudformation-resource-providers-codeartifact#38

no wildcards in handler permissions:
aws-cloudformation/aws-cloudformation-resource-providers-greengrassv2#4
aws-cloudformation/aws-cloudformation-resource-providers-imagebuilder@55fa9bf#r46035310
kddejong pushed a commit to kddejong/cloudformation-cli that referenced this pull request Oct 24, 2022
@PatMyron @kddejong
catch common resource schema issues (aws-cloudformation#663)
b895e70 
resource types with LIST API options like MaxResults, NextToken, Filters, etc as properties of the resource itself:
aws-cloudformation/aws-cloudformation-resource-providers-licensemanager#3
aws-cloudformation/aws-cloudformation-resource-providers-iotwireless#3
aws-cloudformation/aws-cloudformation-resource-providers-ssm#75

readOnlyProperties overlapping with writeOnlyProperties or createOnlyProperties:
aws-cloudformation/aws-cloudformation-resource-providers-auditmanager#2
aws-cloudformation/aws-cloudformation-resource-providers-codeartifact#38

no wildcards in handler permissions:
aws-cloudformation/aws-cloudformation-resource-providers-greengrassv2#4
aws-cloudformation/aws-cloudformation-resource-providers-imagebuilder@55fa9bf#r46035310
awesomedevchris pushed a commit to awesomedevchris/awesome_app that referenced this pull request Apr 10, 2023
@PatMyron
catch common resource schema issues (#663)
aad74bc 
resource types with LIST API options like MaxResults, NextToken, Filters, etc as properties of the resource itself:
aws-cloudformation/aws-cloudformation-resource-providers-licensemanager#3
aws-cloudformation/aws-cloudformation-resource-providers-iotwireless#3
aws-cloudformation/aws-cloudformation-resource-providers-ssm#75

readOnlyProperties overlapping with writeOnlyProperties or createOnlyProperties:
aws-cloudformation/aws-cloudformation-resource-providers-auditmanager#2
aws-cloudformation/aws-cloudformation-resource-providers-codeartifact#38

no wildcards in handler permissions:
aws-cloudformation/aws-cloudformation-resource-providers-greengrassv2#4
aws-cloudformation/aws-cloudformation-resource-providers-imagebuilder@55fa9bf#r46035310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatMyron PatMyron PatMyron left review comments

@jhaashish-stack jhaashish-stack jhaashish-stack approved these changes

@poonamverma-git poonamverma-git poonamverma-git approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itsmanishagarwal @PatMyron @poonamverma-git @jhaashish-stack