New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS::ApplicationInsights::Application minLength/maxLength string constraints instead of minimum/maximum #1

Merged

zhenweig merged 2 commits into aws-cloudformation:master from PatMyron:master

Nov 20, 2020

Contributor

PatMyron commented Nov 3, 2020 •

edited

Loading

@zhenweig
issue for cfn validate to catch these automatically
JSON schema string length constraints
AWS::ApplicationInsights::Application

gsed -i 's/minimum/minLength/' aws-applicationinsights-application/aws-applicationinsights-application.json 
gsed -i 's/maximum/maxLength/' aws-applicationinsights-application/aws-applicationinsights-application.json


          AWS::ApplicationInsights::Application minLength/maxLength string cons…

64146b9

…traints instead of minimum/maximum

aws-cloudformation/cloudformation-cli#414
https://json-schema.org/understanding-json-schema/reference/string.html#length
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-applicationinsights-application.html

PatMyron mentioned this pull request

cfn validate fails for wrong min/max constraint aws-cloudformation/cloudformation-cli#414

Closed

zhenweig approved these changes

View reviewed changes


          Merge branch 'master' into master

63d081e

zhenweig merged commit 07a6d4c into aws-cloudformation:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet