Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS::AccessAnalyzer::Analyzer resourceLink #7

Merged
merged 1 commit into from
Mar 5, 2020
Merged

AWS::AccessAnalyzer::Analyzer resourceLink #7

merged 1 commit into from
Mar 5, 2020

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Feb 21, 2020 •
edited
Loading

aws-cloudformation/cloudformation-coverage-roadmap#139

aws-cloudformation/cloudformation-resource-schema#67

Tested in us-east-1 with this template and URL:

Resources:
  Analyzer:
    Type: AWS::AccessAnalyzer::Analyzer
    Properties:
      Type: ACCOUNT
      AnalyzerName: Name

https://console.aws.amazon.com/access-analyzer/home?region=us-east-1#/analyzer/Name

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@seanmcl
Copy link
Contributor

seanmcl commented Feb 22, 2020

Hi @PatMyron. I'm not working on this right now. @Brimizer is in charge :) Would you please ask for his review?

Best,

Sean

@PatMyron PatMyron requested a review from vladtsir February 28, 2020 18:27
vladtsir
vladtsir approved these changes Mar 4, 2020
View reviewed changes
Copy link

@vladtsir vladtsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful fix.

@PatMyron PatMyron requested a review from miparnisari March 5, 2020 00:42
@PatMyron PatMyron merged commit e3ecc28 into master Mar 5, 2020
@PatMyron PatMyron deleted the PatMyron-patch-1 branch March 26, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladtsir vladtsir vladtsir approved these changes

@miparnisari miparnisari miparnisari approved these changes

@seanmcl seanmcl Awaiting requested review from seanmcl

@Brimizer Brimizer Awaiting requested review from Brimizer

@rjlohan rjlohan Awaiting requested review from rjlohan

@johnttompkins johnttompkins Awaiting requested review from johnttompkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PatMyron @seanmcl @miparnisari @vladtsir