Read the authenticationFlowType value of the configuration
#2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphkim
reviewed
Jun 8, 2021
There was a problem hiding this comment.
Hi @bogren! Thank you for your contribution to the project.
We do not officially support the use-case of programmatically switching between different auth flow types at the moment, but I can see how this PR can provide a potential workaround. We will investigate to see if there are any unintended side effects of this and provide an update.
|
Hi, yes I understand. Thanks, appreciate you looking into the possibilities to get a workaround like this merged. |
Co-authored-by: awsmobilesdk-dev+ghops <[email protected]>
bogren
force-pushed
the
read-custom-auth-value-from-configuration-file
branch
from
6cab3f4 to
5dd838a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #1488. Related to but doesn't fix #684. A small step to show the need for customizing programmatically after the SDK has been initialized.
The change is inspired from the workaround described in aws-amplify/aws-sdk-ios#1204 and the original PR that looks slightly different when it's initially introduced on iOS aws-amplify/aws-sdk-ios#1860.
The idea with the change is to allow us to programmatically change to custom auth before attempting login, calling the custom challenge, then revert the change after the sign in, if we fail the user could change/try a different method.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.