Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: kickoff release #3865

Merged
merged 4 commits into from
Sep 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/issue_comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:

adjust-labels:
runs-on: ubuntu-latest
if: ${{ github.event.issue.state == 'open' }}
permissions:
issues: write
env:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import Foundation

extension StorageCategory: StorageCategoryBehavior {

@available(*, deprecated, message: "Use getURL(path:options:)")
@discardableResult
public func getURL(
key: String,
Expand All @@ -25,6 +26,7 @@ extension StorageCategory: StorageCategoryBehavior {
try await plugin.getURL(path: path, options: options)
}

@available(*, deprecated, message: "Use downloadData(path:options:)")
@discardableResult
public func downloadData(
key: String,
Expand All @@ -41,6 +43,7 @@ extension StorageCategory: StorageCategoryBehavior {
plugin.downloadData(path: path, options: options)
}

@available(*, deprecated, message: "Use downloadFile(path:options:)")
@discardableResult
public func downloadFile(
key: String,
Expand All @@ -59,6 +62,7 @@ extension StorageCategory: StorageCategoryBehavior {
plugin.downloadFile(path: path, local: local, options: options)
}

@available(*, deprecated, message: "Use uploadData(path:options:)")
@discardableResult
public func uploadData(
key: String,
Expand All @@ -77,6 +81,7 @@ extension StorageCategory: StorageCategoryBehavior {
plugin.uploadData(path: path, data: data, options: options)
}

@available(*, deprecated, message: "Use uploadFile(path:options:)")
@discardableResult
public func uploadFile(
key: String,
Expand All @@ -95,6 +100,7 @@ extension StorageCategory: StorageCategoryBehavior {
plugin.uploadFile(path: path, local: local, options: options)
}

@available(*, deprecated, message: "Use remove(path:options:)")
@discardableResult
public func remove(
key: String,
Expand All @@ -111,6 +117,7 @@ extension StorageCategory: StorageCategoryBehavior {
try await plugin.remove(path: path, options: options)
}

@available(*, deprecated, message: "Use list(path:options:)")
@discardableResult
public func list(
options: StorageListOperation.Request.Options? = nil
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,9 @@ class AnalyticsEventSQLStorage: AnalyticsEventStorage {
ORDER BY timestamp ASC
LIMIT ?
"""
let rows = try dbAdapter.executeQuery(queryStatement, [limit])
let rows = try dbAdapter.executeQuery(queryStatement, [limit]).makeIterator()
var result = [PinpointEvent]()
for element in rows {
while let element = try rows.failableNext() {
if let event = PinpointEvent.convertToEvent(element) {
result.append(event)
}
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ Amplify requires Xcode 15.0 or later for all the supported platforms.

## Escape Hatch

All services and features not listed in the [**Features/API sectios**](#featuresapis) are supported via the [Swift SDK](https://github.com/awslabs/aws-sdk-swift) or if supported by a category can be accessed via the Escape Hatch like below:
All services and features not listed in the [**Features/API sections**](#featuresapis) are supported via the [Swift SDK](https://github.com/awslabs/aws-sdk-swift) or if supported by a category can be accessed via the Escape Hatch like below:

```swift
import Amplify
Expand Down
Loading