Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use alias latest and minimum to represent xcode cmd tool version #3465

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

5d
Copy link
Contributor

@5d 5d commented Jan 10, 2024

Issue #

Description

  • add alias latest and minimum to represent xcode cmd tool version
    • latest is xcode 14.3.1
    • minimum is xcode 14.0.1

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d 5d force-pushed the 5d/ci-use-latest-xcode-version branch from d79490b to 2372427 Compare January 10, 2024 20:01
@5d 5d force-pushed the 5d/ci-use-latest-xcode-version branch from 2372427 to c24f70d Compare January 10, 2024 20:23
@5d 5d force-pushed the 5d/ci-use-latest-xcode-version branch from c24f70d to dbddb82 Compare January 10, 2024 20:32
@5d 5d force-pushed the 5d/ci-use-latest-xcode-version branch from dbddb82 to 4ee7955 Compare January 10, 2024 20:43
@5d 5d force-pushed the 5d/ci-use-latest-xcode-version branch from 4ee7955 to 6bc2fd9 Compare January 10, 2024 20:49
@5d 5d force-pushed the 5d/ci-use-latest-xcode-version branch from 6bc2fd9 to fe4a8fc Compare January 10, 2024 21:34
@5d 5d force-pushed the 5d/ci-use-latest-xcode-version branch from fe4a8fc to 769dc05 Compare January 10, 2024 21:48
@5d 5d force-pushed the 5d/ci-use-latest-xcode-version branch from f5d25a2 to 571996d Compare January 10, 2024 22:28
@5d 5d force-pushed the 5d/ci-use-latest-xcode-version branch from 571996d to 769dc05 Compare January 10, 2024 22:40
@5d 5d force-pushed the 5d/ci-use-latest-xcode-version branch from 769dc05 to e155ff7 Compare January 10, 2024 23:01
@5d 5d force-pushed the 5d/ci-use-latest-xcode-version branch from e155ff7 to 1a4b4fd Compare January 10, 2024 23:14
@5d 5d force-pushed the 5d/ci-use-latest-xcode-version branch from 1a4b4fd to 5ed5ce1 Compare January 10, 2024 23:31
@5d 5d force-pushed the 5d/ci-use-latest-xcode-version branch from 5ed5ce1 to abcc9f5 Compare January 10, 2024 23:43
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d8f12a) 68.04% compared to head (60963cb) 68.00%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3465      +/-   ##
==========================================
- Coverage   68.04%   68.00%   -0.04%     
==========================================
  Files        1079     1079              
  Lines       36356    36356              
==========================================
- Hits        24739    24725      -14     
- Misses      11617    11631      +14     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 64.13% <ø> (ø)
Amplify 48.12% <ø> (ø)
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 78.97% <ø> (+0.07%) ⬆️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 81.02% <ø> (-0.33%) ⬇️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.34% <ø> (ø)
Predictions_plugin_unit_test 37.16% <ø> (ø)
PushNotifications_plugin_unit_test 87.13% <ø> (ø)
Storage_plugin_unit_test 77.51% <ø> (ø)
unit_tests 68.00% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@5d 5d marked this pull request as ready for review January 11, 2024 00:02
@5d 5d requested a review from a team as a code owner January 11, 2024 00:02
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:37 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:43 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:43 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:43 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:43 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:43 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:43 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:43 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:43 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 11, 2024 19:43 — with GitHub Actions Inactive
@5d 5d merged commit 3719cca into main Jan 11, 2024
138 checks passed
@5d 5d deleted the 5d/ci-use-latest-xcode-version branch January 11, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants