Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: appsync-realtime-client 3.1.2 watchOS support #3395

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

5d
Copy link
Member

@5d 5d commented Dec 4, 2023

Issue #

Description

Taking on this version of AppSyncRealTimeClient will enable a few use cases from APIPlugin and DataStore

APIPlugin will allow watchOS subscriptions to be established during special circumstances. Otherwise, it wil timeout according to the client timeout logic built in the AppSyncRealTimeClient

DataStore will alow the sync engine to successfully establish subscriptions if disableSubscriptions are set to false.

AppSyncRealTimeClient 3.1.2

https://github.com/aws-amplify/aws-appsync-realtime-client-ios/releases/tag/3.1.2

fix: watchOS support - disable network monitoring, add client timeout (aws-amplify/aws-appsync-realtime-client-ios#141)

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d 5d requested a review from lawmicha December 4, 2023 22:43
@5d 5d marked this pull request as ready for review December 4, 2023 22:43
@5d 5d requested a review from a team as a code owner December 4, 2023 22:43
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71c600d) 67.98% compared to head (54ddb4b) 68.16%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3395      +/-   ##
==========================================
+ Coverage   67.98%   68.16%   +0.18%     
==========================================
  Files        1078     1078              
  Lines       36007    36007              
==========================================
+ Hits        24480    24545      +65     
+ Misses      11527    11462      -65     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 64.45% <ø> (ø)
Amplify 47.81% <ø> (ø)
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 79.46% <ø> (-0.03%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 80.88% <ø> (+1.02%) ⬆️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.09% <ø> (ø)
Predictions_plugin_unit_test 37.29% <ø> (ø)
PushNotifications_plugin_unit_test 87.03% <ø> (ø)
Storage_plugin_unit_test 78.13% <ø> (+0.03%) ⬆️
unit_tests 68.16% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lawmicha lawmicha changed the title chore: update appsync-realtime-client dependency version fix: appsync-realtime-client 3.1.2 watchOS support Dec 5, 2023
@5d 5d merged commit 8379491 into main Dec 5, 2023
76 checks passed
@5d 5d deleted the 5d/update-appsync-client branch December 5, 2023 16:57
@lawmicha
Copy link
Contributor

lawmicha commented Dec 5, 2023

Technically since we take 3.0.0 and up to the next major, this change is only needed for local development to get the latest AppSyncRealTimeClient. The developer consuming the current version of Amplify will be able to pull in the patch version 3.1.2 due to the version rule we have in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants