-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Auth): Using helpers for passwordless workflows #3390
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feat/auth-passwordless #3390 +/- ##
==========================================================
+ Coverage 67.99% 68.01% +0.01%
==========================================================
Files 1091 1094 +3
Lines 36583 36437 -146
==========================================================
- Hits 24873 24781 -92
+ Misses 11710 11656 -54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Support/Helpers/MagicLinkTokenParser.swift
Outdated
Show resolved
Hide resolved
...Plugins/Auth/Tests/AWSCognitoAuthPluginUnitTests/HelperTests/MagicLinkTokenParserTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat(Auth): Using helpers for passwordless workflows * worked on review comments
Description
The PR aims to refactor MagicLink and OTP, to helpers so that code can be reused.
General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.