Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Auth): Using helpers for passwordless workflows #3390

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Nov 29, 2023

Description

The PR aims to refactor MagicLink and OTP, to helpers so that code can be reused.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested a review from a team as a code owner November 29, 2023 21:42
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (87b603f) 67.99% compared to head (2dd8853) 68.01%.

Files Patch % Lines
.../Operations/Helpers/PasswordlessSignInHelper.swift 67.77% 58 Missing ⚠️
...ions/Helpers/PasswordlessConfirmSignInHelper.swift 68.57% 22 Missing ⚠️
...hPlugin/Support/Helpers/MagicLinkTokenParser.swift 80.95% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat/auth-passwordless    #3390      +/-   ##
==========================================================
+ Coverage                   67.99%   68.01%   +0.01%     
==========================================================
  Files                        1091     1094       +3     
  Lines                       36583    36437     -146     
==========================================================
- Hits                        24873    24781      -92     
+ Misses                      11710    11656      -54     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 64.59% <ø> (ø)
Amplify 47.46% <ø> (ø)
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 79.31% <73.66%> (+0.20%) ⬆️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 80.05% <ø> (+0.03%) ⬆️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.09% <ø> (ø)
Predictions_plugin_unit_test 37.29% <ø> (ø)
PushNotifications_plugin_unit_test 87.03% <ø> (ø)
Storage_plugin_unit_test 78.00% <ø> (ø)
unit_tests 68.01% <73.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@thisisabhash thisisabhash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harsh62 harsh62 merged commit 88913fd into feat/auth-passwordless Nov 29, 2023
59 checks passed
@harsh62 harsh62 deleted the refactor-common-usage branch November 29, 2023 22:33
thisisabhash pushed a commit that referenced this pull request Dec 13, 2023
* feat(Auth): Using helpers for passwordless workflows

* worked on review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants