Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): add URLSession client #3387

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Conversation

thisisabhash
Copy link
Member

Issue #

None

Description

  • Add URLSession Client for making HTTP calls to API Gateway Endpoint

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash marked this pull request as ready for review November 29, 2023 05:55
@thisisabhash thisisabhash requested a review from a team as a code owner November 29, 2023 05:55
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (87b603f) 67.99% compared to head (9db7923) 67.88%.
Report is 1 commits behind head on feat/auth-passwordless.

Files Patch % Lines
...pport/Passwordless/AWSAuthPasswordlessClient.swift 7.14% 39 Missing ⚠️
...rt/Passwordless/PreInitiateAuthSignUpPayload.swift 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat/auth-passwordless    #3387      +/-   ##
==========================================================
- Coverage                   67.99%   67.88%   -0.11%     
==========================================================
  Files                        1091     1093       +2     
  Lines                       36583    36636      +53     
==========================================================
- Hits                        24873    24870       -3     
- Misses                      11710    11766      +56     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 64.59% <ø> (ø)
Amplify 47.48% <ø> (+0.01%) ⬆️
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 78.66% <16.66%> (-0.46%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 80.07% <ø> (+0.04%) ⬆️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.09% <ø> (ø)
Predictions_plugin_unit_test 37.29% <ø> (ø)
PushNotifications_plugin_unit_test 87.03% <ø> (ø)
Storage_plugin_unit_test 78.00% <ø> (ø)
unit_tests 67.88% <16.66%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thisisabhash thisisabhash merged commit 25091c9 into feat/auth-passwordless Nov 29, 2023
72 checks passed
@thisisabhash thisisabhash deleted the add-http-client branch November 29, 2023 22:59
thisisabhash added a commit that referenced this pull request Dec 13, 2023
* feat(auth): add URLSession client

* Add mocks

* Fix the unit test build

* Address review comments

* Address review comments

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants