Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): add passwordless request options for magiclink #3385

Merged
merged 1 commit into from
Nov 27, 2023
Merged

feat(auth): add passwordless request options for magiclink #3385

merged 1 commit into from
Nov 27, 2023

Conversation

thisisabhash
Copy link
Member

Issue #

None

Description

  • Add separate request options for magic link public apis
  • Update mock plugin and tests

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested a review from a team as a code owner November 27, 2023 21:56
@thisisabhash thisisabhash requested a review from gpanshu November 27, 2023 21:57
harsh62
harsh62 reviewed Nov 27, 2023
View reviewed changes
Amplify/Categories/Auth/Request/AuthConfirmSignInWithOTPRequest.swift
@@ -13,7 +13,7 @@ public struct AuthConfirmSignInWithOTPRequest: AmplifyOperationRequest {
/// The value of `challengeResponse`is the OTP that is received on the destination provided during sign in request
public let challengeResponse: String

/// Extra request options defined in `AuthPasswordlessOTPRequest.Options`
/// Extra request options defined in `AuthConfirmSignInWithOTPRequest.Options`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@harsh62 harsh62 merged commit 3ad7de2 into feat/auth-passwordless Nov 27, 2023
72 checks passed
@harsh62 harsh62 deleted the update-options branch November 27, 2023 23:44
thisisabhash added a commit that referenced this pull request Dec 13, 2023
@thisisabhash
feat(auth): add passwordless request options for magiclink (#3385)
0e3e247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh62 harsh62 harsh62 approved these changes

@gpanshu gpanshu Awaiting requested review from gpanshu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thisisabhash @harsh62