Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Auth): Add OTP API's and Tasks #3381

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Nov 27, 2023

Description

Add Tasks and API's for OTP. Changes in the PR:

  • Added API's at category and plugin level
  • Created tasks for both Sign In and Confirm Sign In API's
  • Added TODO's that will be updated when the state machine code has been implemented
  • Added new requests for each OTP API because of the different params both API's has. Refer to existing Auth API's.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 marked this pull request as ready for review November 27, 2023 02:33
@harsh62 harsh62 requested a review from a team as a code owner November 27, 2023 02:33
Copy link
Member

@thisisabhash thisisabhash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments LGTM

@harsh62 harsh62 merged commit 75a4039 into feat/auth-passwordless Nov 27, 2023
72 checks passed
@harsh62 harsh62 deleted the add-otp-apis branch November 27, 2023 20:21
thisisabhash pushed a commit that referenced this pull request Dec 13, 2023
* feat(Auth): Add OTP API's and Tasks

* worked on review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants