Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Update public API request and options parameters #3373

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

thisisabhash
Copy link
Member

Issue #

None

Description

Update public API request and options parameters

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested a review from a team as a code owner November 20, 2023 22:50
Copy link
Member

@harsh62 harsh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (4d940a6) 68.19% compared to head (52d982d) 67.99%.

Files Patch % Lines
...uth/Request/AuthPasswordlessMagicLinkRequest.swift 0.00% 4 Missing ⚠️
...ries/Auth/Request/AuthPasswordlessOTPRequest.swift 0.00% 4 Missing ⚠️
...ns/AWSAuthSignUpAndSignInPasswordlessOptions.swift 0.00% 3 Missing ⚠️
...els/Options/AWSAuthSignInPasswordlessOptions.swift 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat/auth-passwordless    #3373      +/-   ##
==========================================================
- Coverage                   68.19%   67.99%   -0.20%     
==========================================================
  Files                        1077     1081       +4     
  Lines                       35967    35980      +13     
==========================================================
- Hits                        24528    24465      -63     
- Misses                      11439    11515      +76     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 64.59% <ø> (ø)
Amplify 47.73% <0.00%> (-0.05%) ⬇️
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 79.51% <0.00%> (-0.01%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 80.05% <ø> (-1.03%) ⬇️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.09% <ø> (ø)
Predictions_plugin_unit_test 37.29% <ø> (ø)
PushNotifications_plugin_unit_test 87.03% <ø> (ø)
Storage_plugin_unit_test 78.00% <ø> (ø)
unit_tests 67.99% <0.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thisisabhash thisisabhash merged commit 19ade33 into feat/auth-passwordless Nov 21, 2023
72 checks passed
@thisisabhash thisisabhash deleted the update-request-options branch November 21, 2023 22:02
thisisabhash added a commit that referenced this pull request Dec 13, 2023
* feat(auth): Update public API request and options parameters

* Update comments

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants