-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): Add magic link API public definitions #3369
feat(auth): Add magic link API public definitions #3369
Conversation
Can you make sure the unit tests pass. This would mean
This would just help us avoid any unforeseen errors in the future. |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feat/auth-passwordless #3369 +/- ##
==========================================================
+ Coverage 68.03% 68.18% +0.14%
==========================================================
Files 1077 1077
Lines 35959 35967 +8
==========================================================
+ Hits 24466 24523 +57
+ Misses 11493 11444 -49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* Add magic link API public definitions * Address review comments * Address review comments
Issue #
None
Description
Add public API definitions for Sign in with Magiclink
General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.