Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Add magic link API public definitions #3369

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

thisisabhash
Copy link
Member

Issue #

None

Description

Add public API definitions for Sign in with Magiclink

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested a review from a team as a code owner November 17, 2023 18:38
@thisisabhash thisisabhash changed the base branch from main to feat/auth-passwordless November 17, 2023 18:38
@harsh62
Copy link
Member

harsh62 commented Nov 17, 2023

Can you make sure the unit tests pass. This would mean

  • Updating the Cognito plugin with no-op methods
  • Updating the mocks..

This would just help us avoid any unforeseen errors in the future.

@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (7b507f3) 68.03% compared to head (fb49c66) 68.18%.

Files Patch % Lines
.../Categories/Auth/AuthCategory+ClientBehavior.swift 0.00% 4 Missing ⚠️
...Behavior/AWSCognitoAuthPlugin+ClientBehavior.swift 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat/auth-passwordless    #3369      +/-   ##
==========================================================
+ Coverage                   68.03%   68.18%   +0.14%     
==========================================================
  Files                        1077     1077              
  Lines                       35959    35967       +8     
==========================================================
+ Hits                        24466    24523      +57     
+ Misses                      11493    11444      -49     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 64.59% <ø> (ø)
Amplify 47.79% <0.00%> (-0.02%) ⬇️
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 79.46% <0.00%> (-0.14%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 81.08% <ø> (+1.02%) ⬆️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.09% <ø> (ø)
Predictions_plugin_unit_test 37.29% <ø> (ø)
PushNotifications_plugin_unit_test 87.03% <ø> (ø)
Storage_plugin_unit_test 78.00% <ø> (ø)
unit_tests 68.18% <0.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thisisabhash thisisabhash merged commit 4d940a6 into feat/auth-passwordless Nov 20, 2023
72 checks passed
@thisisabhash thisisabhash deleted the add-public-defs-magiclink branch November 20, 2023 17:40
thisisabhash added a commit that referenced this pull request Dec 13, 2023
* Add magic link API public definitions

* Address review comments

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants